From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45558) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QLzlA-0005yP-Vj for qemu-devel@nongnu.org; Mon, 16 May 2011 11:31:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QLzl9-0001jv-Nt for qemu-devel@nongnu.org; Mon, 16 May 2011 11:31:04 -0400 Received: from mail-iy0-f173.google.com ([209.85.210.173]:41835) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QLzl9-0001jh-JU for qemu-devel@nongnu.org; Mon, 16 May 2011 11:31:03 -0400 Received: by iym10 with SMTP id 10so4530153iym.4 for ; Mon, 16 May 2011 08:31:02 -0700 (PDT) Date: Mon, 16 May 2011 10:30:57 -0500 From: Jonathan Nieder Message-ID: <20110516153057.GB24316@elie> References: <1288876539-8300-1-git-send-email-kwolf@redhat.com> <1288876539-8300-4-git-send-email-kwolf@redhat.com> <20110516111926.GA7928@elie> <4DD13EFF.80000@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4DD13EFF.80000@redhat.com> Subject: Re: [Qemu-devel] [regression] qemu-system-arm: segfault in lsi_do_command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Stefan Hajnoczi , qemu-devel@nongnu.org Kevin Wolf wrote: > I also reviewed the patch that you mentioned and I can't find anything > suspicious there. I'm afraid you'll have to bite the bullet and run it > with some debugging code yourself (if it's really related to that patch, > you'll want to enable DPRINTF in hw/scsi-disk.c as a first step) I tried reverting a6d96eb7 (scsi: Move sense handling into the driver, 2010-11-24), 78ced65e (scsi-disk: Implement werror for flushes, 2010-10-25), and 8af7a3a (csi-disk: Complete failed requests in scsi_disk_emulate_command, 2010-10-25), and the segfault is gone. So now I also have a nice ARM image to reproduce it more quickly with. :) Here's what the default DPRINTFs write when it segfaults, for what it's worth. I'll try playing with this some more. scsi-disk: Command: lun=0 tag=0x0 data=0x12 0x00 0x00 0x00 0x24 0x00 scsi-disk: Read buf_len=36 scsi-disk: Read sector_count=0 scsi-disk: Command complete tag=0x0 status=0 sense=0 scsi-disk: Command: lun=0 tag=0x10001 data=0x12 0x00 0x00 0x00 0x24 0x00 scsi-disk: Read buf_len=36 scsi-disk: Read sector_count=0 scsi-disk: Command complete tag=0x10001 status=0 sense=0 scsi-disk: Command: lun=0 tag=0x10003 data=0x12 0x00 0x00 0x00 0x24 0x00 scsi-disk: Read buf_len=36 scsi-disk: Read sector_count=0 scsi-disk: Command complete tag=0x10003 status=0 sense=0 scsi-disk: Command: lun=0 tag=0x10005 data=0x12 0x00 0x00 0x00 0x24 0x00 scsi-disk: Read buf_len=36 scsi-disk: Read sector_count=0 scsi-disk: Command complete tag=0x10005 status=0 sense=0 scsi-disk: Command: lun=0 tag=0x10007 data=0x12 0x00 0x00 0x00 0x24 0x00 scsi-disk: Read buf_len=36 scsi-disk: Read sector_count=0 scsi-disk: Command complete tag=0x10007 status=0 sense=0 scsi-disk: Command: lun=0 tag=0x10009 data=0x12 0x00 0x00 0x00 0x24 0x00 scsi-disk: Read buf_len=36 scsi-disk: Read sector_count=0 scsi-disk: Command complete tag=0x10009 status=0 sense=0 scsi-disk: Command: lun=0 tag=0x1000b data=0x12 0x00 0x00 0x00 0x24 0x00 scsi-disk: Read buf_len=36 scsi-disk: Read sector_count=0 scsi-disk: Command complete tag=0x1000b status=0 sense=0 scsi-disk: Command: lun=0 tag=0x1000d data=0x12 0x00 0x00 0x00 0x24 0x00 scsi-disk: Read buf_len=36 scsi-disk: Read sector_count=0 scsi-disk: Command complete tag=0x1000d status=0 sense=0 scsi-disk: Command: lun=0 tag=0x1000f data=0xa0 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x10 0x00 0x00 0x00 scsi-disk: Read buf_len=16 scsi-disk: Read sector_count=0 scsi-disk: Command complete tag=0x1000f status=0 sense=0 scsi-disk: Command: lun=0 tag=0x200 data=0x12 0x00 0x00 0x00 0x24 0x00 scsi-disk: Read buf_len=36 scsi-disk: Read sector_count=0 scsi-disk: Command complete tag=0x200 status=0 sense=0 scsi-disk: Command: lun=0 tag=0x10201 data=0x12 0x00 0x00 0x00 0x24 0x00 scsi-disk: Read buf_len=36 scsi-disk: Read sector_count=0 scsi-disk: Command complete tag=0x10201 status=0 sense=0 scsi-disk: Command: lun=0 tag=0x10203 data=0x12 0x00 0x00 0x00 0x24 0x00 scsi-disk: Read buf_len=36 scsi-disk: Read sector_count=0 scsi-disk: Command complete tag=0x10203 status=0 sense=0 scsi-disk: Command: lun=0 tag=0x10205 data=0x12 0x00 0x00 0x00 0x24 0x00 scsi-disk: Read buf_len=36 scsi-disk: Read sector_count=0 scsi-disk: Command complete tag=0x10205 status=0 sense=0 scsi-disk: Command: lun=0 tag=0x10207 data=0x12 0x00 0x00 0x00 0x24 0x00 scsi-disk: Read buf_len=36 scsi-disk: Read sector_count=0 scsi-disk: Command complete tag=0x10207 status=0 sense=0 scsi-disk: Command: lun=0 tag=0x10209 data=0x12 0x00 0x00 0x00 0x24 0x00 scsi-disk: Read buf_len=36 scsi-disk: Read sector_count=0 scsi-disk: Command complete tag=0x10209 status=0 sense=0 scsi-disk: Command: lun=0 tag=0x1020b data=0x12 0x00 0x00 0x00 0x24 0x00 scsi-disk: Read buf_len=36 scsi-disk: Read sector_count=0 scsi-disk: Command complete tag=0x1020b status=0 sense=0 scsi-disk: Command: lun=0 tag=0x1020d data=0x12 0x00 0x00 0x00 0x24 0x00 scsi-disk: Read buf_len=36 scsi-disk: Read sector_count=0 scsi-disk: Command complete tag=0x1020d status=0 sense=0 scsi-disk: Command: lun=0 tag=0x1020f data=0xa0 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x10 0x00 0x00 0x00 scsi-disk: Read buf_len=16 scsi-disk: Read sector_count=0 scsi-disk: Command complete tag=0x1020f status=0 sense=0 scsi-disk: Command: lun=0 tag=0x10011 data=0x00 0x00 0x00 0x00 0x00 0x00 scsi-disk: Command complete tag=0x10011 status=0 sense=0