From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33191) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QM23v-0007FT-NQ for qemu-devel@nongnu.org; Mon, 16 May 2011 13:58:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QM23u-0007C0-SA for qemu-devel@nongnu.org; Mon, 16 May 2011 13:58:35 -0400 Received: from e4.ny.us.ibm.com ([32.97.182.144]:53862) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QM23u-0007Bv-Pn for qemu-devel@nongnu.org; Mon, 16 May 2011 13:58:34 -0400 Received: from d01relay06.pok.ibm.com (d01relay06.pok.ibm.com [9.56.227.116]) by e4.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p4GHbihD026192 for ; Mon, 16 May 2011 13:37:44 -0400 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay06.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p4GHwXXV1232982 for ; Mon, 16 May 2011 13:58:33 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p4GHwWA5013501 for ; Mon, 16 May 2011 14:58:32 -0300 From: Supriya Kannery Date: Mon, 16 May 2011 23:40:37 +0530 Message-Id: <20110516181037.7142.76146.sendpatchset@skannery> In-Reply-To: <20110516181023.7142.33402.sendpatchset@skannery> References: <20110516181023.7142.33402.sendpatchset@skannery> Subject: [Qemu-devel] [RFC Patch 1/3]Qemu: Enhance "info block" to display cache setting List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Supriya Kannery , Christoph Hellwig , Prerna Saxena Enhance "info block" to display cache setting Example: (qemu) info block ide0-hd0: type=hd removable=0 file=../rhel6-32.qcow2 ro=0 drv=qcow2 encrypted=0 Enhanced to include "cache" setting: (qemu) info block ide0-hd0: type=hd removable=0 cache=none file=../rhel6-32.qcow2 ro=0 drv=qcow2 encrypted=0 Signed-off-by: Supriya Kannery Signed-off-by: Prerna Saxena --- block.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) Index: qemu/block.c =================================================================== --- qemu.orig/block.c +++ qemu/block.c @@ -1713,6 +1713,19 @@ static void bdrv_print_dict(QObject *obj monitor_printf(mon, " locked=%d", qdict_get_bool(bs_dict, "locked")); } + if (qdict_haskey(bs_dict, "open_flags")) { + int open_flags = qdict_get_int(bs_dict, "open_flags"); + if (open_flags & BDRV_O_NOCACHE) { + monitor_printf(mon, " cache=none"); + } else if (open_flags & BDRV_O_CACHE_WB) { + if (open_flags & BDRV_O_NO_FLUSH) + monitor_printf(mon, " cache=unsafe"); + else + monitor_printf(mon, " cache=writeback"); + } else + monitor_printf(mon, " cache=writethrough"); + } + if (qdict_haskey(bs_dict, "inserted")) { QDict *qdict = qobject_to_qdict(qdict_get(bs_dict, "inserted")); @@ -1762,9 +1775,10 @@ void bdrv_info(Monitor *mon, QObject **r } bs_obj = qobject_from_jsonf("{ 'device': %s, 'type': %s, " - "'removable': %i, 'locked': %i }", + "'removable': %i, 'locked': %i, " + "'open_flags': %d }", bs->device_name, type, bs->removable, - bs->locked); + bs->locked, bs->open_flags); if (bs->drv) { QObject *obj;