From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:60027) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QM2dV-0006mQ-G2 for qemu-devel@nongnu.org; Mon, 16 May 2011 14:35:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QM2dU-0005M9-NM for qemu-devel@nongnu.org; Mon, 16 May 2011 14:35:21 -0400 Received: from mail-iy0-f173.google.com ([209.85.210.173]:58200) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QM2dU-0005Lx-KE for qemu-devel@nongnu.org; Mon, 16 May 2011 14:35:20 -0400 Received: by iym10 with SMTP id 10so4699065iym.4 for ; Mon, 16 May 2011 11:35:19 -0700 (PDT) Date: Mon, 16 May 2011 13:35:10 -0500 From: Jonathan Nieder Message-ID: <20110516183425.GA14103@elie> References: <1288876539-8300-1-git-send-email-kwolf@redhat.com> <1288876539-8300-4-git-send-email-kwolf@redhat.com> <20110516111926.GA7928@elie> <4DD13EFF.80000@redhat.com> <20110516154301.GA25150@elie> <4DD149A2.6020801@redhat.com> <4DD15040.7030809@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4DD15040.7030809@redhat.com> Subject: Re: [Qemu-devel] [regression] qemu-system-arm: segfault in lsi_do_command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Kevin Wolf , Stefan Hajnoczi , qemu-devel@nongnu.org Paolo Bonzini wrote: > This fixes it on top of my SCSI refactoring series. Thanks! Works here, too, for what it's worth. I squashed the following in when applying the "scsi: introduce scsi_req_cancel" patch, for easier reading and to get a little closer to warning-free compilation with gcc 4.6. Signed-off-by: Jonathan Nieder --- hw/lsi53c895a.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c index f291283..43de6f8 100644 --- a/hw/lsi53c895a.c +++ b/hw/lsi53c895a.c @@ -889,7 +889,6 @@ static void lsi_do_msgout(LSIState *s) uint8_t msg; int len; uint32_t current_tag; - SCSIDevice *current_dev; lsi_request *current_req, *p, *p_next; int id; @@ -900,8 +899,6 @@ static void lsi_do_msgout(LSIState *s) current_tag = s->select_tag; current_req = lsi_find_by_tag(s, current_tag); } - id = (current_tag >> 8) & 0xf; - current_dev = s->bus.devs[id]; DPRINTF("MSG out len=%d\n", s->dbc); while (s->dbc) { -- 1.7.5.1