From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:47018)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1QMcRv-0002fq-Rg
	for qemu-devel@nongnu.org; Wed, 18 May 2011 04:49:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1QMcRu-0000Tw-KD
	for qemu-devel@nongnu.org; Wed, 18 May 2011 04:49:47 -0400
Received: from mx1.redhat.com ([209.132.183.28]:10291)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1QMcRu-0000Tj-Bo
	for qemu-devel@nongnu.org; Wed, 18 May 2011 04:49:46 -0400
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p4I8nj4c006188
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 18 May 2011 04:49:45 -0400
Date: Wed, 18 May 2011 11:49:40 +0300
From: Alon Levy <alevy@redhat.com>
Message-ID: <20110518084940.GO7083@playa.tlv.redhat.com>
References: <20110516102529.GF27965@playa.redhat.com>
	<1305633825-6171-1-git-send-email-alevy@redhat.com>
	<20110517123209.GF7083@playa.tlv.redhat.com>
	<20110518034240.GL7083@playa.tlv.redhat.com>
	<4DD37245.20009@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4DD37245.20009@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] libcacard: add libcacard.la target
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On Wed, May 18, 2011 at 09:16:21AM +0200, Paolo Bonzini wrote:
> On 05/18/2011 05:42 AM, Alon Levy wrote:
> >>>---
> >>>  Makefile           |   20 +++++++++++++++++++-
> >>>  Makefile.objs      |    3 +++
> >>>  configure          |   12 +++++++++++-
> >>>  libcacard/Makefile |   32 ++++++++++++++++++++++++++++----
> >>>  rules.mak          |    3 +++
> >>>  5 files changed, 64 insertions(+), 6 deletions(-)
> >>>
> >>>diff --git a/Makefile b/Makefile
> >>>index 2b0438c..c71026c 100644
> >>>--- a/Makefile
> >>>+++ b/Makefile
> >>>@@ -119,6 +119,23 @@ version.o: $(SRC_PATH)/version.rc config-host.mak
> >>>
> >>>  version-obj-$(CONFIG_WIN32) += version.o
> >>>  ######################################################################
> >>>+# Support building shared library libcacard
> >>>+
> >>>+.PHONY: libcacard.la install-libcacard
> >>>+ifeq ($(LIBTOOL),)
> >>>+libcacard.la:
> >>>+	@echo libtool is missing, please install and rerun configure
> >>>+
> >>>+install-libcacard:
> >>>+	@echo libtool is missing, please install and rerun configure
> >>>+else
> >>>+libcacard.la: $(GENERATED_HEADERS) $(oslib-obj-y) qemu-malloc.o qemu-timer-common.o $(addsuffix .lo, $(basename $(trace-obj-y)))
> >>>+	$(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C libcacard V="$(V)" TARGET_DIR="$*/" libcacard.la,)
> >>>+
> >>>+install-libcacard: libcacard.la
> >>>+	$(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C libcacard V="$(V)" TARGET_DIR="$*/" install-libcacard,)
> >>>+endif
> 
> If you instead make the .lo rules display the error message (and add
> "; exit 1" after the echo), you can remove this ifeq.  I'll let you
> decide whether to do this or not.

The reason for doing the check at high level and not low level was to avoid
building any prerequisites and then find out no libtool and bail. But I think
I'll add the check at the low level too like you suggest.

> 
> Otherwise looks good, thanks!
> 
> Paolo
>