From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59974) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QMcsv-0006w0-2i for qemu-devel@nongnu.org; Wed, 18 May 2011 05:17:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QMcsu-0005Nu-1d for qemu-devel@nongnu.org; Wed, 18 May 2011 05:17:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22991) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QMcst-0005NA-K7 for qemu-devel@nongnu.org; Wed, 18 May 2011 05:17:39 -0400 Date: Wed, 18 May 2011 12:17:46 +0300 From: "Michael S. Tsirkin" Message-ID: <20110518091746.GK7589@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v2 00/38] pci: initialize ids in pci common code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Isaku Yamahata , kraxel@redhat.com Cc: qemu-devel@nongnu.org On Wed, May 18, 2011 at 01:55:17AM +0900, Isaku Yamahata wrote: > vender id/device id... in pci configuration space are read-only registers > which are commonly defined for all pci devices. > So initialize them in common code and it simplifies the initialization a bit. > I didn't converted virtio-pci and qxl because it determines ids dynaically. > So I'll leave those conversion (or not to convert) to the authors. Hmm, virtio doesn't: static PCIDeviceInfo virtio_info[] = { ... } has the array of devices. qxl has a property to convert device id to 'development' and to tweak revision through a qdev property. Gerd, could you comment on why this is useful? -- MST