From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:49125)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1QMhBt-00030V-JB
	for qemu-devel@nongnu.org; Wed, 18 May 2011 09:53:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1QMhBr-0006EV-6k
	for qemu-devel@nongnu.org; Wed, 18 May 2011 09:53:33 -0400
Received: from mx1.redhat.com ([209.132.183.28]:35596)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1QMhBq-0006EQ-TX
	for qemu-devel@nongnu.org; Wed, 18 May 2011 09:53:31 -0400
Date: Wed, 18 May 2011 10:53:21 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20110518105321.0a39efc7@doriath>
In-Reply-To: <1305679930-4215-4-git-send-email-mdroth@linux.vnet.ibm.com>
References: <1305679930-4215-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<1305679930-4215-4-git-send-email-mdroth@linux.vnet.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v1][ 03/23] error-propagation: build qemu
 with with error-propagation bits
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: aliguori@linux.vnet.ibm.com, qemu-devel@nongnu.org

On Tue, 17 May 2011 19:51:50 -0500
Michael Roth <mdroth@linux.vnet.ibm.com> wrote:

> 
> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
> ---
>  Makefile.objs |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/Makefile.objs b/Makefile.objs
> index c49e44c..0803297 100644
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -15,6 +15,7 @@ oslib-obj-$(CONFIG_POSIX) += oslib-posix.o qemu-thread-posix.o
>  
>  block-obj-y = cutils.o cache-utils.o qemu-malloc.o qemu-option.o module.o async.o
>  block-obj-y += nbd.o block.o aio.o aes.o qemu-config.o qemu-progress.o qemu-sockets.o
> +block-obj-y += error.o
>  block-obj-$(CONFIG_POSIX) += posix-aio-compat.o
>  block-obj-$(CONFIG_LINUX_AIO) += linux-aio.o

This should be squashed in the previous patch, but it won't build as it
depends on a change in qerror.c. I got this problem too, but (I hope that I)
fixed it properly.

I also made two small changes and am working on unit-tests.