From: "Michael S. Tsirkin" <mst@redhat.com>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: kraxel@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 00/38] pci: initialize ids in pci common code
Date: Wed, 18 May 2011 14:34:30 +0300 [thread overview]
Message-ID: <20110518113430.GQ7589@redhat.com> (raw)
In-Reply-To: <20110518105517.GE1705@valinux.co.jp>
On Wed, May 18, 2011 at 07:55:17PM +0900, Isaku Yamahata wrote:
> On Wed, May 18, 2011 at 12:17:46PM +0300, Michael S. Tsirkin wrote:
> > On Wed, May 18, 2011 at 01:55:17AM +0900, Isaku Yamahata wrote:
> > > vender id/device id... in pci configuration space are read-only registers
> > > which are commonly defined for all pci devices.
> > > So initialize them in common code and it simplifies the initialization a bit.
> > > I didn't converted virtio-pci and qxl because it determines ids dynaically.
> > > So I'll leave those conversion (or not to convert) to the authors.
> >
> > Hmm, virtio doesn't:
> > static PCIDeviceInfo virtio_info[] = {
> > ...
> > }
> >
> > has the array of devices.
>
> Okay. I missed it somehow. I get the following, And I'll leave
> qxl convection to Gerd.
Well the devel device id can go it seems, but we
need think what to do with the revision.
Maybe it's not so terrible that revision will
be wrong in -help for qxl - any better ideas?
--
MST
next prev parent reply other threads:[~2011-05-18 11:34 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 16:55 [Qemu-devel] [PATCH v2 00/38] pci: initialize ids in pci common code Isaku Yamahata
2011-05-17 16:55 ` [Qemu-devel] [PATCH v2 01/38] pci: move ids of config space into PCIDeviceInfo Isaku Yamahata
2011-05-17 16:55 ` [Qemu-devel] [PATCH v2 02/38] usb-uhci: convert to PCIDEviceInfo to initialize ids Isaku Yamahata
2011-05-17 16:55 ` [Qemu-devel] [PATCH v2 03/38] eepro100: convert to PCIDeviceInfo " Isaku Yamahata
2011-05-17 16:55 ` [Qemu-devel] [PATCH v2 04/38] dec_pci: " Isaku Yamahata
2011-05-17 16:55 ` [Qemu-devel] [PATCH v2 05/38] apb_pci: " Isaku Yamahata
2011-05-17 16:55 ` [Qemu-devel] [PATCH v2 06/38] ide/piix: " Isaku Yamahata
2011-05-17 16:55 ` [Qemu-devel] [PATCH v2 07/38] vmware_vga.c: " Isaku Yamahata
2011-05-17 16:55 ` [Qemu-devel] [PATCH v2 08/38] hw/ac97.c: " Isaku Yamahata
2011-05-17 16:55 ` [Qemu-devel] [PATCH v2 09/38] hw/acpi_piix4.c: " Isaku Yamahata
2011-05-19 8:10 ` Markus Armbruster
2011-05-19 11:55 ` Isaku Yamahata
2011-05-19 11:59 ` Michael S. Tsirkin
2011-05-19 12:17 ` Isaku Yamahata
2011-05-19 12:36 ` Markus Armbruster
2011-05-19 13:06 ` Isaku Yamahata
2011-05-19 13:43 ` Michael S. Tsirkin
2011-05-17 16:55 ` [Qemu-devel] [PATCH v2 10/38] hw/bonito.c: " Isaku Yamahata
2011-05-17 16:55 ` [Qemu-devel] [PATCH v2 11/38] hw/cirrus_vga.c: " Isaku Yamahata
2011-05-17 16:55 ` [Qemu-devel] [PATCH v2 12/38] hw/e1000.c: " Isaku Yamahata
2011-05-17 16:55 ` [Qemu-devel] [PATCH v2 13/38] hw/es1370.c: " Isaku Yamahata
2011-05-17 16:55 ` [Qemu-devel] [PATCH v2 14/38] hw/grackle_pci.c: " Isaku Yamahata
2011-05-17 16:55 ` [Qemu-devel] [PATCH v2 15/38] hw/gt64xxx.c: " Isaku Yamahata
2011-05-17 16:55 ` [Qemu-devel] [PATCH v2 16/38] hw/ide/cmd646.c: " Isaku Yamahata
2011-05-17 16:55 ` [Qemu-devel] [PATCH v2 17/38] hw/ide/ich.c: " Isaku Yamahata
2011-05-17 16:55 ` [Qemu-devel] [PATCH v2 18/38] hw/ide/via.c: " Isaku Yamahata
2011-05-17 16:55 ` [Qemu-devel] [PATCH v2 19/38] hw/intel-hda.c: " Isaku Yamahata
2011-05-17 16:55 ` [Qemu-devel] [PATCH v2 20/38] hw/ioh3420.c: " Isaku Yamahata
2011-05-17 16:55 ` [Qemu-devel] [PATCH v2 21/38] hw/ivshmem.c: " Isaku Yamahata
2011-05-17 16:55 ` [Qemu-devel] [PATCH v2 22/38] hw/lsi53c895a.c: " Isaku Yamahata
2011-05-17 16:55 ` [Qemu-devel] [PATCH v2 23/38] hw/ne2000.c: " Isaku Yamahata
2011-05-17 16:55 ` [Qemu-devel] [PATCH v2 24/38] hw/pcnet-pci.c: " Isaku Yamahata
2011-05-17 16:55 ` [Qemu-devel] [PATCH v2 25/38] hw/piix4.c: " Isaku Yamahata
2011-05-17 16:55 ` [Qemu-devel] [PATCH v2 26/38] hw/piix_pci.c: " Isaku Yamahata
2011-05-17 16:55 ` [Qemu-devel] [PATCH v2 27/38] hw/qxl.c: " Isaku Yamahata
2011-05-17 16:55 ` [Qemu-devel] [PATCH v2 28/38] hw/rtl8139.c: " Isaku Yamahata
2011-05-17 16:55 ` [Qemu-devel] [PATCH v2 29/38] hw/sh_pci.c: " Isaku Yamahata
2011-05-17 16:55 ` [Qemu-devel] [PATCH v2 30/38] hw/sun4u.c: " Isaku Yamahata
2011-05-17 16:55 ` [Qemu-devel] [PATCH v2 31/38] hw/unin_pci.c: " Isaku Yamahata
2011-05-17 16:55 ` [Qemu-devel] [PATCH v2 32/38] hw/usb-ohci.c: " Isaku Yamahata
2011-05-17 16:55 ` [Qemu-devel] [PATCH v2 33/38] hw/versatile_pci.c: " Isaku Yamahata
2011-05-17 16:55 ` [Qemu-devel] [PATCH v2 34/38] hw/vga-pci.c: " Isaku Yamahata
2011-05-17 16:55 ` [Qemu-devel] [PATCH v2 35/38] hw/vt82c686.c: " Isaku Yamahata
2011-05-17 16:55 ` [Qemu-devel] [PATCH v2 36/38] hw/wdt_i6300esb.c: " Isaku Yamahata
2011-05-17 16:55 ` [Qemu-devel] [PATCH v2 37/38] hw/xio3130_downstream.c: " Isaku Yamahata
2011-05-17 16:55 ` [Qemu-devel] [PATCH v2 38/38] hw/xio3130_upstream.c: " Isaku Yamahata
2011-05-18 2:19 ` [Qemu-devel] [PATCH v2 00/38] pci: initialize ids in pci common code Isaku Yamahata
2011-05-18 9:17 ` Michael S. Tsirkin
2011-05-18 9:26 ` Gerd Hoffmann
2011-05-18 10:55 ` Isaku Yamahata
2011-05-18 11:30 ` Michael S. Tsirkin
2011-05-18 11:34 ` Michael S. Tsirkin [this message]
2011-05-18 13:07 ` Gerd Hoffmann
2011-05-18 13:20 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110518113430.GQ7589@redhat.com \
--to=mst@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).