From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:38514) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QMvxU-0001e0-7c for qemu-devel@nongnu.org; Thu, 19 May 2011 01:39:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QMvxS-0008PR-Qs for qemu-devel@nongnu.org; Thu, 19 May 2011 01:39:40 -0400 Received: from ozlabs.org ([203.10.76.45]:50882) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QMvxS-0008Ov-GO for qemu-devel@nongnu.org; Thu, 19 May 2011 01:39:38 -0400 Date: Thu, 19 May 2011 15:39:34 +1000 From: David Gibson Message-ID: <20110519053934.GH3015@yookeroo.fritz.box> References: <1301023292-24977-1-git-send-email-david@gibson.dropbear.id.au> <1301023292-24977-2-git-send-email-david@gibson.dropbear.id.au> <2F295803-5875-4781-A52D-101CE9DD1DDF@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <2F295803-5875-4781-A52D-101CE9DD1DDF@web.de> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 01/27] Clean up PowerPC SLB handling code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: Alexander Graf , "qemu-devel@nongnu.org Developers" , Kenneth Salerno , paulus@samba.org, anton@samba.org, The OpenBIOS Mailinglist On Thu, May 19, 2011 at 07:35:30AM +0200, Andreas F=E4rber wrote: > Am 25.03.2011 um 04:21 schrieb David Gibson: >=20 > >Currently the SLB information when emulating a PowerPC 970 is > >storeed in a structure with the unhelpfully named fields 'tmp' > >and 'tmp64'. While the layout in these fields does match the > >description of the SLB in the architecture document, it is not > >convenient either for looking up the SLB, or for emulating the > >slbmte instruction. > > > >This patch, therefore, reorganizes the SLB entry structure to be > >divided in the the "ESID related" and "VSID related" fields as > >they are divided in instructions accessing the SLB. > > > >In addition to making the code smaller and more readable, this will > >make it easier to implement for the 1TB segments used in more > >recent PowerPC chips. > > > >Signed-off-by: David Gibson >=20 > According to my bisect, this patch broke ppc64 OpenBIOS. >=20 > David, would you please take a look? Uh, sure. can you describe the symptoms of the breakage, and the exact qemu setup you've observed the problem with? --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other= _ | _way_ _around_! http://www.ozlabs.org/~dgibson