From: Stefan Hajnoczi <stefanha@gmail.com>
To: Arun Thomas <arun.thomas@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] multiboot: set boot_device to first partition
Date: Thu, 19 May 2011 09:17:35 +0100 [thread overview]
Message-ID: <20110519081636.GA8375@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <BANLkTimk4=DcQQmhQd-H+COWeN=cJ45emg@mail.gmail.com>
On Wed, May 18, 2011 at 11:49:26PM +0200, Arun Thomas wrote:
> On Sun, May 1, 2011 at 6:35 PM, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> > On Thu, Apr 28, 2011 at 3:11 PM, Arun Thomas <arun.thomas@gmail.com> wrote:
> >> The multiboot info struct's 'boot_device' field has 'part1' set to 0x01, which
> >> maps to the second primary partition. To specify the first primary partition,
> >> 'part1' should be set to 0x00, since partition numbers start from zero
> >> according to the multiboot spec.
> >>
> >> Signed-off-by: Arun Thomas <arun.thomas@gmail.com>
> >
> > Which OSes have you tested? Xen? Solaris?
>
> I tested Solaris (OpenIndiana Build 148), and it boots fine. I haven't
> been able to try Xen. Linux also boots fine, as expected.
Okay, if Solaris boots that's a good sign. According to the spec your
change is correct, I think this patch should be applied.
Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
next prev parent reply other threads:[~2011-05-19 8:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 14:11 [Qemu-devel] [PATCH] multiboot: set boot_device to first partition Arun Thomas
2011-05-01 16:35 ` Stefan Hajnoczi
2011-05-18 21:49 ` Arun Thomas
2011-05-19 8:17 ` Stefan Hajnoczi [this message]
2011-06-03 20:33 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110519081636.GA8375@stefanha-thinkpad.localdomain \
--to=stefanha@gmail.com \
--cc=arun.thomas@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).