From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46650) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QN49I-0006Mz-6F for qemu-devel@nongnu.org; Thu, 19 May 2011 10:24:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QN49G-0007bp-JW for qemu-devel@nongnu.org; Thu, 19 May 2011 10:24:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63547) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QN49G-0007bW-9E for qemu-devel@nongnu.org; Thu, 19 May 2011 10:24:22 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p4JEOLJ8024018 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 19 May 2011 10:24:21 -0400 Date: Thu, 19 May 2011 19:54:19 +0530 From: Amit Shah Message-ID: <20110519142419.GA29909@amit-x200.redhat.com> References: <1305805037-17752-1-git-send-email-armbru@redhat.com> <1305805037-17752-3-git-send-email-armbru@redhat.com> <20110519131033.GA13222@amit-x200.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 2/4] virtio-serial: Clean up virtser_bus_dev_print() output List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: alevy@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com On (Thu) 19 May 2011 [16:18:29], Markus Armbruster wrote: > Amit Shah writes: > > > On (Thu) 19 May 2011 [13:37:15], Markus Armbruster wrote: > >> Old version looks like this in info qtree (last four lines): > >> > >> dev: virtconsole, id "" > >> dev-prop: is_console = 1 > >> dev-prop: nr = 0 > >> dev-prop: chardev = > >> dev-prop: name = > >> dev-prop-int: id: 0 > >> dev-prop-int: guest_connected: 1 > >> dev-prop-int: host_connected: 0 > >> dev-prop-int: throttled: 0 > >> > >> Indentation is off, and "dev-prop-int" suggests these are properties > >> you can configure with -device, which isn't the case. The other > >> buses' print_dev() callbacks don't do that. For instance, PCI's > >> output looks like this: > >> > >> class Ethernet controller, addr 00:03.0, pci id 1af4:1000 (sub 1af4:0001) > >> bar 0: i/o at 0xffffffffffffffff [0x1e] > >> bar 1: mem at 0xffffffffffffffff [0xffe] > >> bar 6: mem at 0xffffffffffffffff [0xfffe] > >> > >> Change virtser_bus_dev_print() to that style. Result: > >> > >> dev: virtconsole, id "" > >> dev-prop: is_console = 1 > >> dev-prop: nr = 0 > >> dev-prop: chardev = > >> dev-prop: name = > >> port 0, guest on, host off, throttle off > > > > Here the original guest_connected and host_connected meant whether the > > endpoints were open. guest on/off, host on/off don't convey that > > meaning. Can't think of a short version, can you? > > I chose on/off to stay consistent with how qdev shows bool properties > (print_bit() in qdev-properties.c). May be misguided. Like you, I'm > having difficulties coming up with a better version that is still > consise. > > But: should "info qtree" show such device state? It's about > configuration of the device tree, isn't it? Ah; right. guest on/off, throttle are for debug (like debugfs counterpart in the kernel). I guess we'd need a new monitor command to print these out? Amit