qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: "Andreas Färber" <andreas.faerber@web.de>
Cc: Alexander Graf <agraf@suse.de>,
	"	qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
	Kenneth Salerno <kennethsalerno@yahoo.com>,
	paulus@samba.org, anton@samba.org,
	The OpenBIOS Mailinglist <openbios@openbios.org>
Subject: Re: [Qemu-devel] [PATCH 01/27] Clean up PowerPC SLB handling code
Date: Fri, 20 May 2011 13:34:10 +1000	[thread overview]
Message-ID: <20110520033410.GK3015@yookeroo.fritz.box> (raw)
In-Reply-To: <20hoy2vb5wtl5kesvrflxvru.1305793124537@email.android.com>

On Thu, May 19, 2011 at 10:25:04AM +0200, Andreas Färber wrote:
> QEMU HEAD still uses a 32-bit binary for both 32-bit and
> 64-bit. That one uses mtsrin so will need the compatibility, it
> seemed affected, too.
> 
> OpenBIOS SVN HEAD (blob) uses slb* as linked to. We're in the
> preparation of 1.1 and I need to test it before we can update the
> QEMU binary. ;)
> 
> Sorry for top-posting, Android sucks.

So, my theory was half right.  It was a problem with 64-bit mtsr
emulation, but it wasn't that I just removed that code with the SLB
cleanup.  The code was still there and *almost* right.  I was off by
one in one shift, causing the storage key bits to end up in the wrong
place in the SLB entry.  I'll send out the patch right after I've sent
this mail.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

  reply	other threads:[~2011-05-20  3:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-19  8:25 [Qemu-devel] [PATCH 01/27] Clean up PowerPC SLB handling code Andreas Färber
2011-05-20  3:34 ` David Gibson [this message]
2011-05-20  7:50   ` Alexander Graf
  -- strict thread matches above, loose matches on Subject: below --
2011-04-01  4:15 [Qemu-devel] [0/27] Implement emulation of pSeries logical partitions (v6) David Gibson
2011-04-01  4:15 ` [Qemu-devel] [PATCH 01/27] Clean up PowerPC SLB handling code David Gibson
2011-03-25  3:21 [Qemu-devel] [0/27] Implement emulation of pSeries logical partitions (v5) David Gibson
2011-03-25  3:21 ` [Qemu-devel] [PATCH 01/27] Clean up PowerPC SLB handling code David Gibson
2011-05-19  5:35   ` Andreas Färber
2011-05-19  5:39     ` David Gibson
     [not found]       ` <67F15A3F-5EE2-4825-8766-2CA2D6B3356B@web.de>
2011-05-19  6:45         ` David Gibson
2011-03-23  5:30 [Qemu-devel] [0/27] Implement emulation of pSeries logical partitions (v4) David Gibson
2011-03-23  5:30 ` [Qemu-devel] [PATCH 01/27] Clean up PowerPC SLB handling code David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110520033410.GK3015@yookeroo.fritz.box \
    --to=david@gibson.dropbear.id.au \
    --cc=agraf@suse.de \
    --cc=andreas.faerber@web.de \
    --cc=anton@samba.org \
    --cc=kennethsalerno@yahoo.com \
    --cc=openbios@openbios.org \
    --cc=paulus@samba.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).