From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:44662) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QNRxp-0005Tv-5g for qemu-devel@nongnu.org; Fri, 20 May 2011 11:50:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QNRxo-0001KT-B2 for qemu-devel@nongnu.org; Fri, 20 May 2011 11:50:09 -0400 Received: from verein.lst.de ([213.95.11.211]:33577 helo=newverein.lst.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QNRxo-0001KJ-69 for qemu-devel@nongnu.org; Fri, 20 May 2011 11:50:08 -0400 Date: Fri, 20 May 2011 17:50:07 +0200 From: Christoph Hellwig Message-ID: <20110520155007.GB4466@lst.de> References: <1305630067-2119-1-git-send-email-pbonzini@redhat.com> <1305630067-2119-3-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1305630067-2119-3-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 02/21] scsi-generic: Remove bogus double complete List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, David Gibson On Tue, May 17, 2011 at 01:00:48PM +0200, Paolo Bonzini wrote: > scsi-generic scsi_read_complete() should not -both- call the client > complete callback with SCSI_REASON_DATA -and- call > scsi_command_complete(). The former will cause the client to queue a > new read or write request, while the later will free the request data > structure, thus causing the new read or write request to use a > freed/stale structure when it completes. > > This patch fixes the bug, fixing a crash with scsi-generic & RHEL5.5 > installer. Looks good, Reviewed-by: Christoph Hellwig