From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:32951) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QNUYq-0007wq-Bv for qemu-devel@nongnu.org; Fri, 20 May 2011 14:36:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QNUYp-0003Hn-9r for qemu-devel@nongnu.org; Fri, 20 May 2011 14:36:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61333) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QNUYp-0003Hh-07 for qemu-devel@nongnu.org; Fri, 20 May 2011 14:36:31 -0400 Date: Fri, 20 May 2011 19:36:27 +0100 From: "Richard W.M. Jones" Message-ID: <20110520183627.GW27503@amd.home.annexia.org> References: <20110520180331.GA21837@amd.home.annexia.org> <4DD6AEB9.6060506@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4DD6AEB9.6060506@codemonkey.ws> Subject: Re: [Qemu-devel] [PATCH] qemu: json: Fix parsing of integers >= 0x8000000000000000 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, Luiz Capitulino On Fri, May 20, 2011 at 01:11:05PM -0500, Anthony Liguori wrote: > On 05/20/2011 01:03 PM, Richard W.M. Jones wrote: > > > >There seem to be a few unsafe uses of strto* functions. This patch > >just fixes the one that affects me :-) > > Sending an integer of this size is not valid JSON. > > Your patch won't accept negative numbers, correct? > > JSON only supports int64_t. So we should be sending negative numbers for these large addresses? It seems ... ugly ... to me, but OK. We will have to change libvirt. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org