From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:37342)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcmvbkbc@gmail.com>) id 1QNUzr-000693-D3
	for qemu-devel@nongnu.org; Fri, 20 May 2011 15:04:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jcmvbkbc@gmail.com>) id 1QNUzq-00076x-KA
	for qemu-devel@nongnu.org; Fri, 20 May 2011 15:04:27 -0400
Received: from mail-bw0-f45.google.com ([209.85.214.45]:54205)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcmvbkbc@gmail.com>) id 1QNUzq-00076s-9c
	for qemu-devel@nongnu.org; Fri, 20 May 2011 15:04:26 -0400
Received: by bwz16 with SMTP id 16so3508143bwz.4
	for <qemu-devel@nongnu.org>; Fri, 20 May 2011 12:04:25 -0700 (PDT)
From: Max Filippov <jcmvbkbc@gmail.com>
Date: Fri, 20 May 2011 23:04:21 +0400
References: <1305671572-5899-1-git-send-email-jcmvbkbc@gmail.com>
	<1305671572-5899-25-git-send-email-jcmvbkbc@gmail.com>
	<4DD68F9C.4050603@twiddle.net>
In-Reply-To: <4DD68F9C.4050603@twiddle.net>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201105202304.21892.jcmvbkbc@gmail.com>
Subject: Re: [Qemu-devel]
 =?utf-8?q?=5BPATCH_24/26=5D_target-xtensa=3A_impleme?=
 =?utf-8?q?nt_accurate_window=09check?=
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org

> > +static void gen_window_check1(DisasContext *dc, unsigned r1)
> > +{
> > +    if (option_enabled(dc, XTENSA_OPTION_WINDOWED_REGISTER) &&
> > +            r1 / 4 > dc->used_window) {
> > +        TCGv_i32 pc = tcg_const_i32(dc->pc);
> > +        TCGv_i32 w = tcg_const_i32(r1 / 4);
> > +
> > +        gen_advance_ccount(dc);
> > +        gen_helper_window_check(pc, w);
> > +
> > +        tcg_temp_free(w);
> > +        tcg_temp_free(pc);
> > +    }
> 
> dc->used_window is never set to non-zero.  I assume you meant
> to do that here?

Oops (. Thank you, indeed.

Thanks.
-- Max