From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:48192)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1QODz4-0006Zp-QT
	for qemu-devel@nongnu.org; Sun, 22 May 2011 15:06:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1QODz3-00064E-Rw
	for qemu-devel@nongnu.org; Sun, 22 May 2011 15:06:38 -0400
Date: Sun, 22 May 2011 22:06:42 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20110522190642.GA15285@redhat.com>
References: <BANLkTimVJAJL=2Jxe+qDMKPtS8CLagYhBA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <BANLkTimVJAJL=2Jxe+qDMKPtS8CLagYhBA@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] piix_pci: fix piix3_set_irq_pic()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: TeLeMan <geleman@gmail.com>
Cc: qemu-trivial@nongnu.org, Isaku Yamahata <yamahata@valinux.co.jp>, qemu-devel <qemu-devel@nongnu.org>

On Mon, May 16, 2011 at 07:50:55PM +0800, TeLeMan wrote:
> If pic_irq is greater than 7, the irq level is always 0 on 32bits.
> 
> Signed-off-by: TeLeMan <geleman@gmail.com>


Good catch

Acked-by: Michael S. Tsirkin <mst@redhat.com>

> ---
>  hw/piix_pci.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/piix_pci.c b/hw/piix_pci.c
> index 7f1c4cc..85a320e 100644
> --- a/hw/piix_pci.c
> +++ b/hw/piix_pci.c
> @@ -312,7 +312,7 @@ static void piix3_set_irq_pic(PIIX3State *piix3,
> int pic_irq)
>  {
>      qemu_set_irq(piix3->pic[pic_irq],
>                   !!(piix3->pic_levels &
> -                    (((1UL << PIIX_NUM_PIRQS) - 1) <<
> +                    (((1ULL << PIIX_NUM_PIRQS) - 1) <<
>                       (pic_irq * PIIX_NUM_PIRQS))));
>  }
> 
> -- 
> 1.7.3.1.msysgit.0
> --
> SUN OF A BEACH