From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:50561) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QOeQT-00046h-Uy for qemu-devel@nongnu.org; Mon, 23 May 2011 19:20:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QOeQS-0002Xo-Vq for qemu-devel@nongnu.org; Mon, 23 May 2011 19:20:41 -0400 Received: from mail-ey0-f173.google.com ([209.85.215.173]:44663) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QOeQS-0002Xi-Or for qemu-devel@nongnu.org; Mon, 23 May 2011 19:20:40 -0400 Received: by eyb6 with SMTP id 6so2396185eyb.4 for ; Mon, 23 May 2011 16:20:39 -0700 (PDT) From: Max Filippov Date: Tue, 24 May 2011 03:20:35 +0400 References: <1305671572-5899-1-git-send-email-jcmvbkbc@gmail.com> <201105230012.35944.jcmvbkbc@gmail.com> <4DDA664E.108@twiddle.net> In-Reply-To: <4DDA664E.108@twiddle.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201105240320.36147.jcmvbkbc@gmail.com> Subject: Re: [Qemu-devel] [PATCH 21/26] target-xtensa: implement unaligned exception option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org > > This is also done by gen_load_store_alignment. > > Does it really worth copying part of this logic to do_unaligned_access just to use ALIGNED_ONLY framework? > > Yes, because it is done out-of-line, as a part of the TLB load slow path. I probably just don't get what you call 'out-of-line'. In fact do_unaligned_access will be called for every unaligned access, and alignment condition will be checked for every access. It just happens in other place. Does it have more chances to be optimized better than TCG code, or is it less TCG code itself that makes difference? Thanks. -- Max