From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:36362) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QPFDQ-0003IY-0z for qemu-devel@nongnu.org; Wed, 25 May 2011 10:37:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QPFDO-0003NI-SR for qemu-devel@nongnu.org; Wed, 25 May 2011 10:37:39 -0400 Received: from verein.lst.de ([213.95.11.211]:35377 helo=newverein.lst.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QPFDO-0003NC-Nv for qemu-devel@nongnu.org; Wed, 25 May 2011 10:37:38 -0400 Date: Wed, 25 May 2011 15:20:26 +0200 From: Christoph Hellwig Message-ID: <20110525132026.GA2557@lst.de> References: <1306248439-7310-1-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1306248439-7310-1-git-send-email-kwolf@redhat.com> Subject: Re: [Qemu-devel] [PATCH] qcow2: Fix in-flight list after qcow2_cache_put failure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org On Tue, May 24, 2011 at 04:47:19PM +0200, Kevin Wolf wrote: > If qcow2_cache_put returns an error during cluster allocation and the > allocation fails, it must be removed from the list of in-flight allocations. > Otherwise we'd get a loop in the list when the ACB is used for the next > allocation. > > Luckily, this qcow2_cache_put shouldn't fail anyway because the L2 table is > only read, so that qcow2_cache_put doesn't even involve I/O. Looks good, Reviewed-by: Christoph Hellwig