From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:46914)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1QPwKr-00054v-Dp
	for qemu-devel@nongnu.org; Fri, 27 May 2011 08:40:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1QPwKq-0000zx-Ij
	for qemu-devel@nongnu.org; Fri, 27 May 2011 08:40:13 -0400
Received: from mx1.redhat.com ([209.132.183.28]:4290)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1QPwKq-0000zt-AV
	for qemu-devel@nongnu.org; Fri, 27 May 2011 08:40:12 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p4RCeBTM027293
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 27 May 2011 08:40:11 -0400
Date: Fri, 27 May 2011 18:10:08 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20110527124008.GA2461@amit-x200.redhat.com>
References: <20110526152929.36c15abf@doriath>
	<20110527112916.GA31810@amit-x200.redhat.com>
	<20110527113430.GB31810@amit-x200.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110527113430.GB31810@amit-x200.redhat.com>
Subject: Re: [Qemu-devel] block bug: tray status is not updated (and/or
	guest ignores it)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: kwolf@redhat.com, Markus Armbruster <armbru@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

On (Fri) 27 May 2011 [17:04:30], Amit Shah wrote:
> On (Fri) 27 May 2011 [17:01:35], Amit Shah wrote:
> > On (Thu) 26 May 2011 [15:29:29], Luiz Capitulino wrote:
> > > 
> > > I'm testing with qemu.git (HEAD aa29141d84d), procedure:
> > > 
> > > 1. Start a VM with:
> > > 
> > >  # qemu -hda disks/test.img -enable-kvm -m 1G -cdrom Fedora-14-x86_64-DVD.iso
> > > 
> > > 2. Then inside the guest run:
> > > 
> > >  # eject /dev/sr0 && mount /dev/sr0 /mnt
> > > 
> > > Results:
> > > 
> > >  Actual: The cdrom is successfully mounted
> > >  Expected: The cdrom is not mounted (mount fails, medium not found)
> > 
> > Really?  That's what you expect? :-)
> > 
> > Where will the medium go?
> > 
> > What happens is mount auto-closes the tray and mounts whatever is
> > there, which is the image you provided.  Works as expected, IMO.

Confirmed, that's what happens.

What's weird though is 'eject' in the monitor makes the cdrom go away
-- a subsequent mount in the guest results in a no medium error.  I
thought we had solved that, Markus?

By not doing a bdrv_close() in the do_eject()->eject_device() call
path this starts working as expected.

		Amit