From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53865) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QQ1RN-0007kC-Em for qemu-devel@nongnu.org; Fri, 27 May 2011 14:07:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QQ1RM-0003uV-Ba for qemu-devel@nongnu.org; Fri, 27 May 2011 14:07:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10283) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QQ1RM-0003uL-3N for qemu-devel@nongnu.org; Fri, 27 May 2011 14:07:16 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p4RI7F5l005831 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 27 May 2011 14:07:15 -0400 Date: Fri, 27 May 2011 19:07:10 +0100 From: "Daniel P. Berrange" Message-ID: <20110527180710.GA26348@redhat.com> References: <20110526152929.36c15abf@doriath> <20110527112916.GA31810@amit-x200.redhat.com> <20110527113430.GB31810@amit-x200.redhat.com> <20110527124008.GA2461@amit-x200.redhat.com> <20110527103935.4a9b652e@doriath> <20110527134112.GK22589@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] block bug: tray status is not updated (and/or guest ignores it) Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Amit Shah , kwolf@redhat.com, qemu-devel , Luiz Capitulino On Fri, May 27, 2011 at 04:35:24PM +0200, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > > On Fri, May 27, 2011 at 10:39:35AM -0300, Luiz Capitulino wrote: > >> On Fri, 27 May 2011 18:10:08 +0530 > >> Amit Shah wrote: > [...] > >> > What's weird though is 'eject' in the monitor makes the cdrom go away > >> > -- a subsequent mount in the guest results in a no medium error. I > >> > thought we had solved that, Markus? > >> > > >> > By not doing a bdrv_close() in the do_eject()->eject_device() call > >> > path this starts working as expected. > >> > >> Yes, also note that with the -f option eject is capable of purging > >> any block device. I wonder if libvirt (or any client) relies on this. > > > > libvirt will only issue 'eject' on devices which are CDROMs, or Floppy, > > never hard disks, etc. > > Any use of -f? Recommend to stay away from it. > > https://bugzilla.redhat.com/show_bug.cgi?id=676528 When ejecting CDROM media, there's an option to supply a 'FORCE' flag to the libvirt API, so media is ejected even if the guest OS has locked the tray, or is crashed Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|