From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:50247) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QQszM-0007sY-JB for qemu-devel@nongnu.org; Sun, 29 May 2011 23:17:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QQszI-0006Lr-Oj for qemu-devel@nongnu.org; Sun, 29 May 2011 23:17:56 -0400 Received: from ozlabs.org ([203.10.76.45]:48584) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QQszI-0006LH-Bf for qemu-devel@nongnu.org; Sun, 29 May 2011 23:17:52 -0400 Date: Mon, 30 May 2011 13:17:43 +1000 From: David Gibson Message-ID: <20110530031743.GC5926@yookeroo.fritz.box> References: <1306237507-19189-1-git-send-email-pbonzini@redhat.com> <1306237507-19189-4-git-send-email-pbonzini@redhat.com> <20110524221441.GB11809@yookeroo.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 3/3] spapr: make irq customizable via qdev List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Paolo Bonzini , qemu-devel@nongnu.org, agraf@suse.de On Wed, May 25, 2011 at 05:13:40PM +0200, Markus Armbruster wrote: > David Gibson writes: > > > On Tue, May 24, 2011 at 01:45:07PM +0200, Paolo Bonzini wrote: > >> Signed-off-by: Paolo Bonzini > >> Cc: Alexander Graf > >> Cc: David Gibson > >> --- > >> hw/spapr_vio.c | 8 +++++++- > >> 1 files changed, 7 insertions(+), 1 deletions(-) > >> > >> diff --git a/hw/spapr_vio.c b/hw/spapr_vio.c > >> index be535d6..fee4c46 100644 > >> --- a/hw/spapr_vio.c > >> +++ b/hw/spapr_vio.c > >> @@ -52,6 +52,10 @@ > >> static struct BusInfo spapr_vio_bus_info = { > >> .name = "spapr-vio", > >> .size = sizeof(VIOsPAPRBus), > >> + .props = (Property[]) { > >> + DEFINE_PROP_UINT32("irq", VIOsPAPRDevice, vio_irq_num, 0), \ > >> + DEFINE_PROP_END_OF_LIST(), > >> + }, > >> }; > > > > I don't see what the point of this is. Absolute irq numbers have no > > special meaning in the XICS context, and the guest kernel will remap > > them to virtual irqs anyway. > > Are the irq numbers guest-visible? Yes. > If yes, a property may be required > to keep them stable across migration. Especially when hot-plug comes > into play. Ah, yes, that's a point. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson