From: "Roedel, Joerg" <Joerg.Roedel@amd.com>
To: Avi Kivity <avi@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Nadav Har'El <nyh@math.technion.ac.il>, kvm <kvm@vger.kernel.org>,
john cooper <john.cooper@redhat.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] drop -enable-nesting
Date: Tue, 31 May 2011 11:06:17 +0200 [thread overview]
Message-ID: <20110531090617.GC7855@amd.com> (raw)
In-Reply-To: <4DE4ADA8.5000503@redhat.com>
On Tue, May 31, 2011 at 04:58:16AM -0400, Avi Kivity wrote:
> On 05/31/2011 11:44 AM, Daniel P. Berrange wrote:
> > > I think it's safe to drop -enable-nesting immediately. Dan, does
> > > libvirt make use of it?
> >
> > Yes, but it should be safe to drop it. Currently, if the user specifies
> > a CPU with the 'svm' flag present in libvirt guest XML, then we will
> > pass args '-cpu ....+svm -enable-nesting'. So if we drop --enable-nesting,
> > then libvirt will simply omit it and everything should still work because
> > we have still got +svm set.
>
> But qemu will complain about an option it can't parse.
The best choice is probably to keep the option and make it a nop for the
lifetime of qemu-kvm. Optionally qemu-kvm can print a warning about the
deprecated option.
Joerg
--
AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2011-05-31 9:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 21:46 [Qemu-devel] [PATCH 3/7] cpu model bug fixes and definition corrections: Add kvm emulated x2apic flag to config defined cpu models john cooper
2011-05-28 8:39 ` Jan Kiszka
2011-05-30 8:18 ` Roedel, Joerg
2011-05-30 14:04 ` [Qemu-devel] drop -enable-nesting (was: [PATCH 3/7] cpu model bug fixes and definition corrections...) Jan Kiszka
2011-05-30 14:38 ` Nadav Har'El
2011-05-30 15:04 ` [Qemu-devel] drop -enable-nesting Jan Kiszka
2011-05-30 15:10 ` Roedel, Joerg
2011-05-30 15:15 ` Jan Kiszka
2011-05-30 15:19 ` Avi Kivity
2011-05-30 15:27 ` Jan Kiszka
2011-05-30 15:42 ` Jan Kiszka
2011-05-31 8:44 ` Daniel P. Berrange
2011-05-31 8:58 ` Avi Kivity
2011-05-31 9:06 ` Roedel, Joerg [this message]
2011-05-31 9:15 ` Paolo Bonzini
2011-05-31 9:16 ` Avi Kivity
2011-05-30 15:16 ` Nadav Har'El
2011-05-30 15:59 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110531090617.GC7855@amd.com \
--to=joerg.roedel@amd.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=john.cooper@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=nyh@math.technion.ac.il \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).