From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:47225)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <B07421@freescale.com>) id 1QSXjn-00023y-9Y
	for qemu-devel@nongnu.org; Fri, 03 Jun 2011 13:00:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <B07421@freescale.com>) id 1QSXjm-00085f-00
	for qemu-devel@nongnu.org; Fri, 03 Jun 2011 13:00:43 -0400
Received: from tx2ehsobe003.messaging.microsoft.com ([65.55.88.13]:47646
	helo=TX2EHSOBE006.bigfish.com) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <B07421@freescale.com>) id 1QSXjl-00085T-FK
	for qemu-devel@nongnu.org; Fri, 03 Jun 2011 13:00:41 -0400
Date: Fri, 3 Jun 2011 12:00:36 -0500
From: Scott Wood <scottwood@freescale.com>
Message-ID: <20110603120036.3408086a@schlenkerla.am.freescale.net>
In-Reply-To: <1307015870-22191-1-git-send-email-agraf@suse.de>
References: <1307015870-22191-1-git-send-email-agraf@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] PPC: E500: Implement reboot controller
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>

On Thu, 2 Jun 2011 13:57:50 +0200
Alexander Graf <agraf@suse.de> wrote:

> diff --git a/pc-bios/mpc8544ds.dts b/pc-bios/mpc8544ds.dts
> index 872152d..9b95bfd 100644
> --- a/pc-bios/mpc8544ds.dts
> +++ b/pc-bios/mpc8544ds.dts
> @@ -82,6 +82,12 @@
>  			compatible = "chrp,open-pic";
>  			device_type = "open-pic";
>  		};
> +
> +                global-utilities@e0000 {        //global utilities block
> +                        compatible = "fsl,mpc8548-guts";
> +                        reg = <0xe0000 0x1000>;
> +                        fsl,has-rstcr;
> +                };
>  	};

We're not providing a full mpc8548 (or mpc8544) guts, only the rstcr
register.

Currently Linux looks for a node with the name "global-utilities" and a
property "fsl,has-rstcr", so there's no compatibility reason for a
misleading compatible, either.

I'd go with compatible = "fsl,guts-rstcr" (what we've been using
internally, and would be a nicer thing to bind against than what the
kernel currently does).  Or if the goal is to provide more guts registers
later, use "fsl,mpc8544-guts" and have qemu log a warning if other accesses
are made.

-Scott