From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:59260)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1QSXLy-0004Xr-FT
	for qemu-devel@nongnu.org; Fri, 03 Jun 2011 12:36:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1QSXLw-0004Hh-II
	for qemu-devel@nongnu.org; Fri, 03 Jun 2011 12:36:06 -0400
Received: from hall.aurel32.net ([88.191.126.93]:35768)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1QSXLw-0004HX-64
	for qemu-devel@nongnu.org; Fri, 03 Jun 2011 12:36:04 -0400
Date: Fri, 3 Jun 2011 18:35:59 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20110603163559.GA14583@volta.aurel32.net>
References: <20110531054345.GA17412@amit-x200.redhat.com>
	<1306828429-9139-1-git-send-email-cfergeau@redhat.com>
	<1306828429-9139-2-git-send-email-cfergeau@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <1306828429-9139-2-git-send-email-cfergeau@redhat.com>
Subject: Re: [Qemu-devel] [PATCH-v3 1/2] tcg: Fix unused-but-set-variable
 warning
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christophe Fergeau <cfergeau@redhat.com>
Cc: qemu-devel@nongnu.org

On Tue, May 31, 2011 at 09:53:48AM +0200, Christophe Fergeau wrote:
> Based on a patch from Hans de Goede <hdegoede@redhat.com>
> 
> This warning is new in gcc 4.6.
> 
> Acked-by: Amit Shah <amit.shah@redhat.com>
> Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
> ---
>  tcg/tcg.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Thanks, applied.

> diff --git a/tcg/tcg.c b/tcg/tcg.c
> index 8748c05..e53b54c 100644
> --- a/tcg/tcg.c
> +++ b/tcg/tcg.c
> @@ -585,7 +585,7 @@ void tcg_register_helper(void *func, const char *name)
>  void tcg_gen_callN(TCGContext *s, TCGv_ptr func, unsigned int flags,
>                     int sizemask, TCGArg ret, int nargs, TCGArg *args)
>  {
> -#ifdef TCG_TARGET_I386
> +#if defined(TCG_TARGET_I386) && TCG_TARGET_REG_BITS < 64
>      int call_type;
>  #endif
>      int i;
> @@ -612,7 +612,7 @@ void tcg_gen_callN(TCGContext *s, TCGv_ptr func, unsigned int flags,
>  
>      *gen_opc_ptr++ = INDEX_op_call;
>      nparam = gen_opparam_ptr++;
> -#ifdef TCG_TARGET_I386
> +#if defined(TCG_TARGET_I386) && TCG_TARGET_REG_BITS < 64
>      call_type = (flags & TCG_CALL_TYPE_MASK);
>  #endif
>      if (ret != TCG_CALL_DUMMY_ARG) {
> -- 
> 1.7.5.2
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net