From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:36421)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1QSXSe-0006DD-UL
	for qemu-devel@nongnu.org; Fri, 03 Jun 2011 12:43:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1QSXSd-0005Gr-0i
	for qemu-devel@nongnu.org; Fri, 03 Jun 2011 12:43:00 -0400
Received: from hall.aurel32.net ([88.191.126.93]:50446)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1QSXSc-0005Gn-Jg
	for qemu-devel@nongnu.org; Fri, 03 Jun 2011 12:42:58 -0400
Date: Fri, 3 Jun 2011 18:42:56 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20110603164256.GA6870@hall.aurel32.net>
References: <4D8C745F.2000304@sysgo.com>
	<AANLkTimB_OYKtjCOXrSe5RSNKiYTR6YUN7paVU=gELEf@mail.gmail.com>
	<4DD398CE.9040603@sysgo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <4DD398CE.9040603@sysgo.com>
Sender: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] ARM: BKPT instructions should raise prefetch
 aborts with IFSR type 00010
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Zuepke <azuepke@sysgo.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org

On Wed, May 18, 2011 at 12:00:46PM +0200, Alex Zuepke wrote:
> Hi,
> 
> Peter Maydell schrieb:
> > On 25 March 2011 10:54, Alex Zuepke <azuepke@sysgo.com> wrote:
> >> while digging through some problems with BKPT exceptions on ARM, I
> >> discovered that QEMU does not update IFSR on prefetch aborts. This
> >> should be done since ARMv6 according to ARM docs. Please include.
> > 
> > This patch is the wrong approach to fixing this bug -- the
> > updating of the IFSR needs to be done when the exception
> > is taken, not when we translate the breakpoint instruction.
> > 
> > I'll put this on my todo list. If you happen to have a convenient
> > test case demonstrating the problem, that would make a fix happen
> > faster ;-)
> > 
> > -- PMM
> 
> I tried to fix it, new patch attached.
> But I'm not sure if it is required for semihosting as well.
> 
> On ARMv7-M bkpt works differently, and debug registers aren't
> implemented yet, so I didn't touch it.
> 

Thanks, applied. In the future, could you please send the patch inline,
or at least attach a patch that can be applied with git am?

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net