From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:45627)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1QScg3-0002q6-Qn
	for qemu-devel@nongnu.org; Fri, 03 Jun 2011 18:17:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1QScg2-0007nH-3n
	for qemu-devel@nongnu.org; Fri, 03 Jun 2011 18:17:11 -0400
Received: from hall.aurel32.net ([88.191.126.93]:46621)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1QScg1-0007n6-Mq
	for qemu-devel@nongnu.org; Fri, 03 Jun 2011 18:17:09 -0400
Date: Sat, 4 Jun 2011 00:17:07 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20110603221707.GI14583@volta.aurel32.net>
References: <BANLkTim7utDK7kQn-zKUGyF8QTMMF4Sqog@mail.gmail.com>
	<20110603203309.GB14583@volta.aurel32.net>
	<alpine.LNX.2.00.1106040156530.3183@linmac>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <alpine.LNX.2.00.1106040156530.3183@linmac>
Subject: Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in
 configure
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>, qemu-devel@nongnu.org

On Sat, Jun 04, 2011 at 01:57:23AM +0400, malc wrote:
> On Fri, 3 Jun 2011, Aurelien Jarno wrote:
> 
> > On Fri, Apr 29, 2011 at 05:59:19PM +0200, Marc-Antoine Perennou wrote:
> > > pulse/simple.h does not include stdlib.h
> > > We cannot use NULL since it may not be defined
> > > Use 0 instead
> > 
> > I am unable to reproduce this issue, even with gcc-4.6. Also please note
> > that NULL is defined in <stddef.h>, not <stdlib.h>. <stddef.h> is 
> > included from <sys/types.h> which is included from <pulse/simple.h>.
> > 
> > Do you have more information about the issue.
> > 
> > > Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
> > > ---
> > >  configure |    2 +-
> > >  1 files changed, 1 insertions(+), 1 deletions(-)
> > > 
> > > diff --git a/configure b/configure
> > > index ea8b676..d67c3ce 100755
> > > --- a/configure
> > > +++ b/configure
> > > @@ -1567,7 +1567,7 @@ for drv in $audio_drv_list; do
> > > 
> > >      pa)
> > >      audio_drv_probe $drv pulse/simple.h "-lpulse-simple -lpulse" \
> > > -        "pa_simple *s = NULL; pa_simple_free(s); return 0;"
> > > +        "pa_simple *s = 0; pa_simple_free(s); return 0;"
> > 
> > It should be ((void*)0) instead of simply 0.
> 
> No it shouldn't.
> 

If we want to replace #include <stddef.h>, which should use the same
code, that is:

| #ifndef __cplusplus
| #define NULL ((void *)0)
| #else   /* C++ */
| #define NULL 0
| #endif  /* C++ */

Given we are writing C code and not C++ code, NULL is defined as 
((void *)0).

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net