[Qemu-devel] [Bug 793317] [NEW] Large amount of write-only variables

[Qemu-devel] [Bug 793317] [NEW] Large amount of write-only variables

[Eli]

Public bug reported:

Whenever I try to compile the source from the git repo, it gets a large
number of "set but not used" errors, in files such as:

hw/usb_ochi.c (line 526, 1114, and 1108)
hw/lsi53c895a.c (line 892)
kvm.c (line 973)
target-alpha/translate.c (line 1472, 1470)
linux-user/syscall.c (line 7062, 3754)
exec.c (line 1211)
linux-user/linuxload.c (line 60)

Really now, why would anyone create so many write-only variables knowing
that it's compiled with write-only variables causing errors..?

Host: Fedora 15 i686
Gcc: 4.6.0
Guest: None
I pulled the code from the git repo earlier today, so I'm pretty sure it did not get fixed in that short timeframe.

** Affects: qemu
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/793317

Title:
  Large amount of write-only variables

Status in QEMU:
  New

Bug description:
  Whenever I try to compile the source from the git repo, it gets a
  large number of "set but not used" errors, in files such as:

  hw/usb_ochi.c (line 526, 1114, and 1108)
  hw/lsi53c895a.c (line 892)
  kvm.c (line 973)
  target-alpha/translate.c (line 1472, 1470)
  linux-user/syscall.c (line 7062, 3754)
  exec.c (line 1211)
  linux-user/linuxload.c (line 60)

  Really now, why would anyone create so many write-only variables
  knowing that it's compiled with write-only variables causing errors..?

  Host: Fedora 15 i686
  Gcc: 4.6.0
  Guest: None
  I pulled the code from the git repo earlier today, so I'm pretty sure it did not get fixed in that short timeframe.

[Qemu-devel] [Bug 793317] Re: Large amount of write-only variables

[Brad Hards]

I don't have a file called hw/usb_ochi.c. Did you mean hw/usb-ohci.c?

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/793317

Title:
  Large amount of write-only variables

Status in QEMU:
  New

Bug description:
  Whenever I try to compile the source from the git repo, it gets a
  large number of "set but not used" errors, in files such as:

  hw/usb_ochi.c (line 526, 1114, and 1108)
  hw/lsi53c895a.c (line 892)
  kvm.c (line 973)
  target-alpha/translate.c (line 1472, 1470)
  linux-user/syscall.c (line 7062, 3754)
  exec.c (line 1211)
  linux-user/linuxload.c (line 60)

  Really now, why would anyone create so many write-only variables
  knowing that it's compiled with write-only variables causing errors..?

  Host: Fedora 15 i686
  Gcc: 4.6.0
  Guest: None
  I pulled the code from the git repo earlier today, so I'm pretty sure it did not get fixed in that short timeframe.

[Qemu-devel] [Bug 793317] Re: Large amount of write-only variables

[Eli]

Yeah, i meant usb-ohci.c.

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/793317

Title:
  Large amount of write-only variables

Status in QEMU:
  New

Bug description:
  Whenever I try to compile the source from the git repo, it gets a
  large number of "set but not used" errors, in files such as:

  hw/usb_ochi.c (line 526, 1114, and 1108)
  hw/lsi53c895a.c (line 892)
  kvm.c (line 973)
  target-alpha/translate.c (line 1472, 1470)
  linux-user/syscall.c (line 7062, 3754)
  exec.c (line 1211)
  linux-user/linuxload.c (line 60)

  Really now, why would anyone create so many write-only variables
  knowing that it's compiled with write-only variables causing errors..?

  Host: Fedora 15 i686
  Gcc: 4.6.0
  Guest: None
  I pulled the code from the git repo earlier today, so I'm pretty sure it did not get fixed in that short timeframe.

[Qemu-devel] [Bug 793317] Re: Large amount of write-only variables

[Brad Hards]

Ok, looking at the first example (line 526), I see code that looks like:

static inline int ohci_put_iso_td(OHCIState *ohci,
                                  uint32_t addr, struct ohci_iso_td *td)
{
    return (put_dwords(ohci, addr, (uint32_t *)td, 4) &&
            put_words(ohci, addr + 16, td->offset, 8));
}

Is that what you see? Because I don't see any variables that are only
set.

Of course you're using a newer compiler, but I'm still not sure I can
see the problem.

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/793317

Title:
  Large amount of write-only variables

Status in QEMU:
  New

Bug description:
  Whenever I try to compile the source from the git repo, it gets a
  large number of "set but not used" errors, in files such as:

  hw/usb_ochi.c (line 526, 1114, and 1108)
  hw/lsi53c895a.c (line 892)
  kvm.c (line 973)
  target-alpha/translate.c (line 1472, 1470)
  linux-user/syscall.c (line 7062, 3754)
  exec.c (line 1211)
  linux-user/linuxload.c (line 60)

  Really now, why would anyone create so many write-only variables
  knowing that it's compiled with write-only variables causing errors..?

  Host: Fedora 15 i686
  Gcc: 4.6.0
  Guest: None
  I pulled the code from the git repo earlier today, so I'm pretty sure it did not get fixed in that short timeframe.

[Qemu-devel] [Bug 793317] Re: Large amount of write-only variables

[Eli]

Whoa. I completely messed up there. It's usb-ehci.c, I just thought of
usb-ohci.c off the top of my head as it was way back in the console
logs.

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/793317

Title:
  Large amount of write-only variables

Status in QEMU:
  New

Bug description:
  Whenever I try to compile the source from the git repo, it gets a
  large number of "set but not used" errors, in files such as:

  hw/usb_ochi.c (line 526, 1114, and 1108)
  hw/lsi53c895a.c (line 892)
  kvm.c (line 973)
  target-alpha/translate.c (line 1472, 1470)
  linux-user/syscall.c (line 7062, 3754)
  exec.c (line 1211)
  linux-user/linuxload.c (line 60)

  Really now, why would anyone create so many write-only variables
  knowing that it's compiled with write-only variables causing errors..?

  Host: Fedora 15 i686
  Gcc: 4.6.0
  Guest: None
  I pulled the code from the git repo earlier today, so I'm pretty sure it did not get fixed in that short timeframe.

[Qemu-devel] [Bug 793317] Re: Large amount of write-only variables

[Brad Hards]

I'm still confused.
hw/usb-ehci.c line 526 is just a variable declaration:
    uint8_t *pci_conf;

Line 529 looks like an unused assignment, but nothing I see on line 526.

Would it be possible for you to double check the work, and possible
paste the error message instead of summarising them?

Brad

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/793317

Title:
  Large amount of write-only variables

Status in QEMU:
  New

Bug description:
  Whenever I try to compile the source from the git repo, it gets a
  large number of "set but not used" errors, in files such as:

  hw/usb_ochi.c (line 526, 1114, and 1108)
  hw/lsi53c895a.c (line 892)
  kvm.c (line 973)
  target-alpha/translate.c (line 1472, 1470)
  linux-user/syscall.c (line 7062, 3754)
  exec.c (line 1211)
  linux-user/linuxload.c (line 60)

  Really now, why would anyone create so many write-only variables
  knowing that it's compiled with write-only variables causing errors..?

  Host: Fedora 15 i686
  Gcc: 4.6.0
  Guest: None
  I pulled the code from the git repo earlier today, so I'm pretty sure it did not get fixed in that short timeframe.

[Qemu-devel] [Bug 793317] Re: Large amount of write-only variables

[Eli]

Yeah, that would be incredibly useful. I just wrote down a list of
approximate line numbers and filenames for them, as I needed it to
compile so just inserted dummy if() statements to "access" the
variables. There are also a bunch more than I posted, those were just
examples.

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/793317

Title:
  Large amount of write-only variables

Status in QEMU:
  New

Bug description:
  Whenever I try to compile the source from the git repo, it gets a
  large number of "set but not used" errors, in files such as:

  hw/usb_ochi.c (line 526, 1114, and 1108)
  hw/lsi53c895a.c (line 892)
  kvm.c (line 973)
  target-alpha/translate.c (line 1472, 1470)
  linux-user/syscall.c (line 7062, 3754)
  exec.c (line 1211)
  linux-user/linuxload.c (line 60)

  Really now, why would anyone create so many write-only variables
  knowing that it's compiled with write-only variables causing errors..?

  Host: Fedora 15 i686
  Gcc: 4.6.0
  Guest: None
  I pulled the code from the git repo earlier today, so I'm pretty sure it did not get fixed in that short timeframe.

Re: [Qemu-devel] [Bug 793317] [NEW] Large amount of write-only variables

[David Gibson]

On Mon, Jun 06, 2011 at 01:02:33AM -0000, Eli wrote:
> Public bug reported:
> 
> Whenever I try to compile the source from the git repo, it gets a large
> number of "set but not used" errors, in files such as:
> 
> hw/usb_ochi.c (line 526, 1114, and 1108)
> hw/lsi53c895a.c (line 892)
> kvm.c (line 973)
> target-alpha/translate.c (line 1472, 1470)
> linux-user/syscall.c (line 7062, 3754)
> exec.c (line 1211)
> linux-user/linuxload.c (line 60)
> 
> Really now, why would anyone create so many write-only variables knowing
> that it's compiled with write-only variables causing errors..?

It's a new warning in gcc 4.6, which is why these weren't found
before.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Re: [Qemu-devel] [Bug 793317] [NEW] Large amount of write-only variables

[agraf]

On 06.06.2011, at 08:06, David Gibson wrote:

> On Mon, Jun 06, 2011 at 01:02:33AM -0000, Eli wrote:
>> Public bug reported:
>> 
>> Whenever I try to compile the source from the git repo, it gets a large
>> number of "set but not used" errors, in files such as:
>> 
>> hw/usb_ochi.c (line 526, 1114, and 1108)
>> hw/lsi53c895a.c (line 892)
>> kvm.c (line 973)
>> target-alpha/translate.c (line 1472, 1470)
>> linux-user/syscall.c (line 7062, 3754)
>> exec.c (line 1211)
>> linux-user/linuxload.c (line 60)
>> 
>> Really now, why would anyone create so many write-only variables knowing
>> that it's compiled with write-only variables causing errors..?
> 
> It's a new warning in gcc 4.6, which is why these weren't found
> before.

Yeah, for a quick compile workaround, use ./configure --disable-werror.
Otherwise, please send patches that get rid of the write-only variables.
People simply didn't get warnings on them before, which is why they
slipped through.

Alex

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/793317

Title:
  Large amount of write-only variables

Status in QEMU:
  New

Bug description:
  Whenever I try to compile the source from the git repo, it gets a
  large number of "set but not used" errors, in files such as:

  hw/usb_ochi.c (line 526, 1114, and 1108)
  hw/lsi53c895a.c (line 892)
  kvm.c (line 973)
  target-alpha/translate.c (line 1472, 1470)
  linux-user/syscall.c (line 7062, 3754)
  exec.c (line 1211)
  linux-user/linuxload.c (line 60)

  Really now, why would anyone create so many write-only variables
  knowing that it's compiled with write-only variables causing errors..?

  Host: Fedora 15 i686
  Gcc: 4.6.0
  Guest: None
  I pulled the code from the git repo earlier today, so I'm pretty sure it did not get fixed in that short timeframe.

[Qemu-devel] [Bug 793317] Re: Large amount of write-only variables

[Christophe Fergeau]

Patches were already sent to the ML, see the "[PATCH 00/14] More gcc 4.6
warnings fixes" and "[PATCH 0/3] Fix unused-but-set-variable warnings"
threads

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/793317

Title:
  Large amount of write-only variables

Status in QEMU:
  New

Bug description:
  Whenever I try to compile the source from the git repo, it gets a
  large number of "set but not used" errors, in files such as:

  hw/usb_ochi.c (line 526, 1114, and 1108)
  hw/lsi53c895a.c (line 892)
  kvm.c (line 973)
  target-alpha/translate.c (line 1472, 1470)
  linux-user/syscall.c (line 7062, 3754)
  exec.c (line 1211)
  linux-user/linuxload.c (line 60)

  Really now, why would anyone create so many write-only variables
  knowing that it's compiled with write-only variables causing errors..?

  Host: Fedora 15 i686
  Gcc: 4.6.0
  Guest: None
  I pulled the code from the git repo earlier today, so I'm pretty sure it did not get fixed in that short timeframe.

[Qemu-devel] [Bug 793317] Re: Large amount of write-only variables

[Peter Maydell]

We fixed all our set-but-not-used warnings for QEMU 1.0.


** Changed in: qemu
       Status: New => Fix Released

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/793317

Title:
  Large amount of write-only variables

Status in QEMU:
  Fix Released

Bug description:
  Whenever I try to compile the source from the git repo, it gets a
  large number of "set but not used" errors, in files such as:

  hw/usb_ochi.c (line 526, 1114, and 1108)
  hw/lsi53c895a.c (line 892)
  kvm.c (line 973)
  target-alpha/translate.c (line 1472, 1470)
  linux-user/syscall.c (line 7062, 3754)
  exec.c (line 1211)
  linux-user/linuxload.c (line 60)

  Really now, why would anyone create so many write-only variables
  knowing that it's compiled with write-only variables causing errors..?

  Host: Fedora 15 i686
  Gcc: 4.6.0
  Guest: None
  I pulled the code from the git repo earlier today, so I'm pretty sure it did not get fixed in that short timeframe.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/793317/+subscriptions