From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:49523)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1QTb4P-0000C5-Nh
	for qemu-devel@nongnu.org; Mon, 06 Jun 2011 10:46:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1QTb4N-0007HG-V8
	for qemu-devel@nongnu.org; Mon, 06 Jun 2011 10:46:21 -0400
Received: from mx1.redhat.com ([209.132.183.28]:21093)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1QTb4N-0007Gz-3J
	for qemu-devel@nongnu.org; Mon, 06 Jun 2011 10:46:19 -0400
Date: Mon, 6 Jun 2011 11:46:15 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20110606114615.0fe5e424@doriath>
In-Reply-To: <m3boyb6qs9.fsf@blackfin.pond.sub.org>
References: <1307127842-12102-1-git-send-email-lcapitulino@redhat.com>
	<1307127842-12102-5-git-send-email-lcapitulino@redhat.com>
	<m3boyb6qs9.fsf@blackfin.pond.sub.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC 04/10] HMP: info block: Print the 'tray-open'
 key
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, amit.shah@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org

On Mon, 06 Jun 2011 15:19:34 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> Luiz Capitulino <lcapitulino@redhat.com> writes:
> 
> > It's printed before the "[not inserted]" or the "file" fields, like this:
> >
> >  (qemu) info block
> >  ide0-hd0: removable=0 file=disks/test.img ro=0 drv=qcow2 encrypted=0
> >  ide1-cd0: removable=1 locked=0 tray-open=0 file=/Fedora-14-x86_64-DVD.iso ro=1 drv=raw encrypted=0
> >  floppy0: removable=1 locked=0 tray-open=0 [not inserted]
> >  sd0: removable=1 locked=0 tray-open=0 [not inserted]
> >  (qemu)
> >
> > TODO: Confirm this won't break libvirt.
> 
> As far as I can see, libvirt uses neither "info block" nor
> "query-block".

Thanks for checking it.

> I'd squash this into the previous commit.
>