From: "Daniel P. Berrange" <berrange@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>,
jdenemar@redhat.com, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason
Date: Mon, 6 Jun 2011 16:27:55 +0100 [thread overview]
Message-ID: <20110606152755.GI23745@redhat.com> (raw)
In-Reply-To: <4DECD163.9030704@codemonkey.ws>
On Mon, Jun 06, 2011 at 08:08:51AM -0500, Anthony Liguori wrote:
> On 06/06/2011 04:25 AM, Kevin Wolf wrote:
> >Am 02.06.2011 20:09, schrieb Luiz Capitulino:
> >>>>I'm ok with either way. But in case you meant the second one, I guess
> >>>>we should make "reason" a dictionary so that we can group related
> >>>>information when we extend the field, for example:
> >>>>
> >>>> "reason": { "no space": false, "no permission": true }
> >
> >Splitting up enums into a number of booleans looks like a bad idea to
> >me. It makes things more verbose than they should be, and even worse, it
> >implies that more than one field could be true.
>
> I agree. What I had suggested was to not have a reason at all.
>
> >
> >If this new schema thing doesn't support proper enums, that's something
> >that should be changed.
>
> It does BTW.
>
> >>>
> >>>Why would we ever have "no permission"?
> >>
> >>It's an I/O error. I have a report from a developer who was getting
> >>the BLOCK_IO_ERROR event and had to debug qemu to know the error cause,
> >>it turned out to be no permission.
> >
> >And I want to add that it's a PITA to handle bug report when the only
> >message you get from qemu is "something went wrong". Sorry, that's not
> >useful at all. I want to see the real error reason (and at least for
> >debugging this means, I want to see the errno value/string).
> >
> >Finding out that it was -EACCES in fact cost me (and QA who ran into the
> >problem) much more time than it should have. It's simply too much that
> >you need to attach gdb to find out what really happened.
>
> You want a log file and you want libvirt to actually let QEMU write
> to a log file.
Anything QEMU writes to stderr or stdout gets recorded in a
per-VM logfile already at /var/log/libvirt/qemu/$GUESTNAME.log
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
next prev parent reply other threads:[~2011-06-06 15:28 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 21:12 [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason Luiz Capitulino
2011-06-01 21:35 ` Anthony Liguori
2011-06-02 9:06 ` Daniel P. Berrange
2011-06-02 13:08 ` Anthony Liguori
2011-06-02 13:24 ` Jiri Denemark
2011-06-02 14:02 ` Anthony Liguori
2011-06-02 18:01 ` Luiz Capitulino
2011-06-02 18:32 ` Anthony Liguori
2011-06-02 18:57 ` Luiz Capitulino
2011-06-02 19:35 ` Anthony Liguori
2011-06-03 9:26 ` Daniel P. Berrange
2011-06-03 12:43 ` Anthony Liguori
2011-06-03 12:57 ` Daniel P. Berrange
2011-06-03 13:26 ` Anthony Liguori
2011-06-03 13:39 ` Daniel P. Berrange
2011-06-03 13:44 ` Luiz Capitulino
2011-06-03 14:01 ` Anthony Liguori
2011-06-03 13:41 ` Jan Kiszka
2011-06-03 13:51 ` Anthony Liguori
2011-06-03 13:59 ` Jan Kiszka
2011-06-03 14:03 ` Daniel P. Berrange
2011-06-06 11:21 ` Markus Armbruster
2011-06-02 17:57 ` Luiz Capitulino
2011-06-02 18:00 ` Anthony Liguori
2011-06-02 18:09 ` Luiz Capitulino
2011-06-02 18:33 ` Anthony Liguori
2011-06-02 19:13 ` Luiz Capitulino
2011-06-02 20:03 ` Anthony Liguori
2011-06-02 20:13 ` [Qemu-devel] [libvirt] " Eric Blake
2011-06-02 20:55 ` Anthony Liguori
2011-06-06 9:25 ` [Qemu-devel] " Kevin Wolf
2011-06-06 11:27 ` Markus Armbruster
2011-06-06 13:09 ` Anthony Liguori
2011-06-06 13:08 ` Anthony Liguori
2011-06-06 15:27 ` Daniel P. Berrange [this message]
2011-06-06 15:30 ` Luiz Capitulino
2011-06-08 12:59 ` Anthony Liguori
2011-06-07 14:46 ` Luiz Capitulino
2011-06-07 15:39 ` Anthony Liguori
2011-06-07 15:54 ` Luiz Capitulino
2011-06-07 16:32 ` Anthony Liguori
2011-06-07 17:43 ` Luiz Capitulino
2011-06-07 18:43 ` Anthony Liguori
2011-06-07 18:48 ` Luiz Capitulino
2011-06-07 15:41 ` Markus Armbruster
2011-06-07 16:31 ` Anthony Liguori
2011-06-06 11:13 ` Markus Armbruster
2011-06-06 11:28 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110606152755.GI23745@redhat.com \
--to=berrange@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=jdenemar@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).