From: Marcelo Tosatti <mtosatti@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, Marcelo Tosatti <mtosatti@redhat.com>,
Jes.Sorensen@redhat.com, dlaor@redhat.com, avi@redhat.com,
jdenemar@redhat.com
Subject: [Qemu-devel] [patch 7/7] do not allow migration if block copy in progress
Date: Mon, 06 Jun 2011 13:55:43 -0300 [thread overview]
Message-ID: <20110606165823.918331609@amt.cnet> (raw)
In-Reply-To: 20110606165536.581119615@amt.cnet
[-- Attachment #1: 3-3-do-not-allow-migration-if-block-copy-in-progress.patch --]
[-- Type: text/plain, Size: 911 bytes --]
Disable live migration with in progress live copy, due to:
- Conflict with block migration.
- Block copy does not support migration ATM.
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Index: qemu-block-copy/migration.c
===================================================================
--- qemu-block-copy.orig/migration.c
+++ qemu-block-copy/migration.c
@@ -19,6 +19,7 @@
#include "block.h"
#include "qemu_socket.h"
#include "block-migration.h"
+#include "block-copy.h"
#include "qemu-objects.h"
//#define DEBUG_MIGRATION
@@ -95,6 +96,11 @@ int do_migrate(Monitor *mon, const QDict
return -1;
}
+ if (block_copy_active()) {
+ monitor_printf(mon, "block copy in progress\n");
+ return -1;
+ }
+
if (strstart(uri, "tcp:", &p)) {
s = tcp_start_outgoing_migration(mon, p, max_throttle, detach,
blk, inc);
next prev parent reply other threads:[~2011-06-06 17:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 16:55 [Qemu-devel] [patch 0/7] live block copy (v4) Marcelo Tosatti
2011-06-06 16:55 ` [Qemu-devel] [patch 1/7] add migration_active function Marcelo Tosatti
2011-06-06 16:55 ` [Qemu-devel] [patch 2/7] Add blkmirror block driver Marcelo Tosatti
2011-06-06 21:52 ` malc
2011-06-07 10:25 ` Stefan Hajnoczi
2011-06-06 16:55 ` [Qemu-devel] [patch 3/7] Add error messages for live block copy Marcelo Tosatti
2011-06-06 16:55 ` [Qemu-devel] [patch 4/7] Add blkdebug points " Marcelo Tosatti
2011-06-06 16:55 ` [Qemu-devel] [patch 5/7] Add vmstop code " Marcelo Tosatti
2011-06-06 16:55 ` [Qemu-devel] [patch 6/7] QEMU " Marcelo Tosatti
2011-06-06 17:03 ` [Qemu-devel] [patch 6/7] QEMU live block copy (update) Marcelo Tosatti
2011-06-07 10:15 ` Jiri Denemark
2011-06-15 15:49 ` Marcelo Tosatti
2011-06-15 15:51 ` Marcelo Tosatti
2011-06-07 12:15 ` [Qemu-devel] [patch 6/7] QEMU live block copy Stefan Hajnoczi
2011-06-08 15:10 ` Jagane Sundar
2011-06-08 16:18 ` Stefan Hajnoczi
2011-06-09 15:42 ` Jagane Sundar
2011-06-15 16:59 ` Marcelo Tosatti
2011-06-06 16:55 ` Marcelo Tosatti [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-05-23 21:31 [Qemu-devel] [patch 0/7] live block copy (v3) Marcelo Tosatti
2011-05-23 21:31 ` [Qemu-devel] [patch 7/7] do not allow migration if block copy in progress Marcelo Tosatti
2011-05-29 8:54 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110606165823.918331609@amt.cnet \
--to=mtosatti@redhat.com \
--cc=Jes.Sorensen@redhat.com \
--cc=avi@redhat.com \
--cc=dlaor@redhat.com \
--cc=jdenemar@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).