qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: "Andreas Färber" <andreas.faerber@web.de>
Cc: qemu-trivial@nongnu.org, Paul Brook <paul@codesourcery.com>,
	Laurent Vivier <Laurent@vivier.eu>,
	QEMU-devel Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] m68k: Replace gen_im32() by tcg_const_i32()
Date: Tue, 7 Jun 2011 14:56:19 +0100	[thread overview]
Message-ID: <20110607135619.GC1493@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <78A4F565-9ABF-4B0E-885A-573D42DF1211@web.de>

On Sun, Jun 05, 2011 at 12:26:18PM +0200, Andreas Färber wrote:
> I would add as description: "This resolves a FIXME."
> 
> Is "by" grammatically correct here? I would've thought to replace
> sth. "with" sth., by s.o.
> 
> Am 25.03.2011 um 20:36 schrieb Laurent Vivier:
> 
> >Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> 
> This patch accurately inlines and removes gen_im32().
> 
> Reviewed-by: Andreas Färber <andreas.faerber@web.de>
> 
> Stefan, this patch was sent the third time already, nobody else
> commented. It applies cleanly and compiles. Can we consider it a
> trivial patch and be done with it?
> 
> http://patchwork.ozlabs.org/patch/88417/

Thanks, applied to the trivial patches tree:
http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches

Stefan

      reply	other threads:[~2011-06-07 13:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-25 19:36 [Qemu-devel] [PATCH] m68k: Replace gen_im32() by tcg_const_i32() Laurent Vivier
2011-06-05 10:26 ` Andreas Färber
2011-06-07 13:56   ` Stefan Hajnoczi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110607135619.GC1493@stefanha-thinkpad.localdomain \
    --to=stefanha@gmail.com \
    --cc=Laurent@vivier.eu \
    --cc=andreas.faerber@web.de \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).