From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:37411)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QTwlt-00020E-QS
	for qemu-devel@nongnu.org; Tue, 07 Jun 2011 09:56:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QTwlp-0002pp-95
	for qemu-devel@nongnu.org; Tue, 07 Jun 2011 09:56:41 -0400
Date: Tue, 7 Jun 2011 14:56:19 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20110607135619.GC1493@stefanha-thinkpad.localdomain>
References: <1301081796-25364-1-git-send-email-laurent@vivier.eu>
	<78A4F565-9ABF-4B0E-885A-573D42DF1211@web.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <78A4F565-9ABF-4B0E-885A-573D42DF1211@web.de>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] m68k: Replace gen_im32() by
 tcg_const_i32()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?iso-8859-1?Q?F=E4rber?= <andreas.faerber@web.de>
Cc: qemu-trivial@nongnu.org, Paul Brook <paul@codesourcery.com>, Laurent Vivier <Laurent@vivier.eu>, QEMU-devel Developers <qemu-devel@nongnu.org>

On Sun, Jun 05, 2011 at 12:26:18PM +0200, Andreas Färber wrote:
> I would add as description: "This resolves a FIXME."
> 
> Is "by" grammatically correct here? I would've thought to replace
> sth. "with" sth., by s.o.
> 
> Am 25.03.2011 um 20:36 schrieb Laurent Vivier:
> 
> >Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> 
> This patch accurately inlines and removes gen_im32().
> 
> Reviewed-by: Andreas Färber <andreas.faerber@web.de>
> 
> Stefan, this patch was sent the third time already, nobody else
> commented. It applies cleanly and compiles. Can we consider it a
> trivial patch and be done with it?
> 
> http://patchwork.ozlabs.org/patch/88417/

Thanks, applied to the trivial patches tree:
http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches

Stefan