From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40869) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QULrF-0003eM-TQ for qemu-devel@nongnu.org; Wed, 08 Jun 2011 12:43:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QULrD-0007eG-CX for qemu-devel@nongnu.org; Wed, 08 Jun 2011 12:43:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1029) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QULrC-0007ck-ML for qemu-devel@nongnu.org; Wed, 08 Jun 2011 12:43:51 -0400 Date: Wed, 8 Jun 2011 13:43:46 -0300 From: Luiz Capitulino Message-ID: <20110608134346.59daaa8e@doriath> In-Reply-To: <1307140399-9023-1-git-send-email-mdroth@linux.vnet.ibm.com> References: <1307140399-9023-1-git-send-email-mdroth@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [QAPI+QGA 2/3] QAPI code generation infrastructure v2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: aliguori@linux.vnet.ibm.com, agl@linux.vnet.ibm.com, qemu-devel@nongnu.org, Jes.Sorensen@redhat.com On Fri, 3 Jun 2011 17:32:58 -0500 Michael Roth wrote: > This is Set 2/3 of the QAPI+QGA patchsets. I have started taking a look at this series, but it turns out that this is complex stuff and I'd like to spend time playing with it and testing it throughly. I don't oppose merging this as is, as this series doesn't touch current QMP. So I assume we'll have enough time to fix possible bugs before doing a mass conversion. The only problem is that all the patches have my signed off but I haven't really reviewed them[*], so I'd feel more comfortable if they were removed before merging (or that you wait for my review). * I guess that happened because Michael pulled from my repo and my git am hook has the '-s' flag...