From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:42429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QUN2a-0007ry-4z for qemu-devel@nongnu.org; Wed, 08 Jun 2011 13:59:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QUN2Y-0005Ar-DS for qemu-devel@nongnu.org; Wed, 08 Jun 2011 13:59:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36343) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QUN2X-0005Ah-Qz for qemu-devel@nongnu.org; Wed, 08 Jun 2011 13:59:38 -0400 Date: Wed, 8 Jun 2011 14:59:33 -0300 From: Luiz Capitulino Message-ID: <20110608145933.0e1485c9@doriath> In-Reply-To: <4DEFAB48.9070205@linux.vnet.ibm.com> References: <1307140399-9023-1-git-send-email-mdroth@linux.vnet.ibm.com> <20110608134346.59daaa8e@doriath> <4DEFAB48.9070205@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [QAPI+QGA 2/3] QAPI code generation infrastructure v2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: aliguori@linux.vnet.ibm.com, agl@linux.vnet.ibm.com, qemu-devel@nongnu.org, Jes.Sorensen@redhat.com On Wed, 08 Jun 2011 12:03:04 -0500 Michael Roth wrote: > On 06/08/2011 11:43 AM, Luiz Capitulino wrote: > > On Fri, 3 Jun 2011 17:32:58 -0500 > > Michael Roth wrote: > > > >> This is Set 2/3 of the QAPI+QGA patchsets. > > > > I have started taking a look at this series, but it turns out that this is > > complex stuff and I'd like to spend time playing with it and testing it > > throughly. > > > > I don't oppose merging this as is, as this series doesn't touch current QMP. > > So I assume we'll have enough time to fix possible bugs before doing a mass > > conversion. > > Yah, it's fairly well isolated from the rest of qemu. The error and json > stuff (set1) was the only bit that would have an affect on qemu/qmp > behavior, and that's been merged. Yes. > > The only problem is that all the patches have my signed off but I haven't > > really reviewed them[*], so I'd feel more comfortable if they were removed > > before merging (or that you wait for my review). > > > > * I guess that happened because Michael pulled from my repo and my git am > > hook has the '-s' flag... > > Doh, yah the sign-offs were included in the commits I pulled. Sorry > about that. > > To be clear though, are you referring to patches 1-3 of set1? I don't > see your sign-off in any patches in this set. Doh, you're right. I was looking at my private branch (where I use my git am alias). There's nothing we can do about set1 anyway. Sorry for the noise.