From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:35094) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QUP8d-0003xv-K0 for qemu-devel@nongnu.org; Wed, 08 Jun 2011 16:14:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QUP8b-0002n9-R2 for qemu-devel@nongnu.org; Wed, 08 Jun 2011 16:14:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64755) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QUP8b-0002n1-98 for qemu-devel@nongnu.org; Wed, 08 Jun 2011 16:14:01 -0400 Date: Wed, 8 Jun 2011 23:14:16 +0300 From: "Michael S. Tsirkin" Message-ID: <20110608201416.GA31791@redhat.com> References: <32d12d55df0a3a98b7f05b3be5e896fe148d59f4.1307528800.git.jan.kiszka@siemens.com> <20110608144313.GS32149@valinux.co.jp> <4DEF8B35.10901@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4DEF8B35.10901@siemens.com> Subject: Re: [Qemu-devel] [PATCH 6/7] msix: Align MSI-X constants to libpci definitions and extend them List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Isaku Yamahata , qemu-devel On Wed, Jun 08, 2011 at 04:46:13PM +0200, Jan Kiszka wrote: > On 2011-06-08 16:43, Isaku Yamahata wrote: > > On Wed, Jun 08, 2011 at 12:26:44PM +0200, Jan Kiszka wrote: > >> Add PCI_MSIX_TABLE and PCI_MSIX_PBA, align other MSIX related constant > >> names to libpci style. Will be used for device assignment code in > >> qemu-kvm. > > > > So since libpci would be used by qemu, you are claiming that > > it should be switched to libpci style from Linux pci_regs.h? > > No, libpci won't be used (I'm about to remove that dependency from > qemu-kvm). We are just copying its definitions, so I think we should > align to its style. > > Jan But why? We are currently aligned with pci_regs.h from linux. What is the benefit of switching styles? It adds support overhead e.g. as backport becomes harder. BTW, libpci doesn't seem to have pci_regs.h - it has pci/header.h If some register definitions are missing in linux, what we did in the past is: - stick them in a C file that needs them meanwhile - long term add them to linux and backport to our header We could also add pci_ext_regs.h or something to this end as an alternative, although this removes the pressure to upstream definitions ... > -- > Siemens AG, Corporate Technology, CT T DE IT 1 > Corporate Competence Center Embedded Linux