From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:51628)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1QUPnL-0005Q7-TQ
	for qemu-devel@nongnu.org; Wed, 08 Jun 2011 16:56:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1QUPnK-0001Aa-Dw
	for qemu-devel@nongnu.org; Wed, 08 Jun 2011 16:56:07 -0400
Received: from mx1.redhat.com ([209.132.183.28]:17254)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1QUPnK-0001AO-0F
	for qemu-devel@nongnu.org; Wed, 08 Jun 2011 16:56:06 -0400
Date: Wed, 8 Jun 2011 23:56:22 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20110608205622.GA32260@redhat.com>
References: <cover.1307550106.git.jan.kiszka@siemens.com>
	<b653b747d8b3107a16e491464ea6669129845367.1307550106.git.jan.kiszka@siemens.com>
	<20110608194845.GC30805@redhat.com> <4DEFDF4A.1010501@web.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4DEFDF4A.1010501@web.de>
Subject: Re: [Qemu-devel] [PATCH v2 9/9] msi: Move PCI_MSI_PENDING_32/64
	into pci_regs.h
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: qemu-devel <qemu-devel@nongnu.org>

On Wed, Jun 08, 2011 at 10:44:58PM +0200, Jan Kiszka wrote:
> On 2011-06-08 21:48, Michael S. Tsirkin wrote:
> > On Wed, Jun 08, 2011 at 06:21:52PM +0200, Jan Kiszka wrote:
> >> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> > 
> > pci_regs.h from linux does not have these
> > this is why we keep them in msi.c
> > 
> > [mst@tuck linux-2.6]$ grep PCI_MSI_ include/linux/pci_regs.h 
> > #define PCI_MSI_FLAGS           2       /* Various flags */
> > #define  PCI_MSI_FLAGS_64BIT    0x80    /* 64-bit addresses allowed */
> > #define  PCI_MSI_FLAGS_QSIZE    0x70    /* Message queue size configured
> > */
> > #define  PCI_MSI_FLAGS_QMASK    0x0e    /* Maximum queue size available
> > */
> > #define  PCI_MSI_FLAGS_ENABLE   0x01    /* MSI feature enabled */
> > #define  PCI_MSI_FLAGS_MASKBIT  0x100   /* 64-bit mask bits allowed */
> > #define PCI_MSI_RFU             3       /* Rest of capability flags */
> > #define PCI_MSI_ADDRESS_LO      4       /* Lower 32 bits */
> > #define PCI_MSI_ADDRESS_HI      8       /* Upper 32 bits (if
> > PCI_MSI_FLAGS_64BIT set) */
> > #define PCI_MSI_DATA_32         8       /* 16 bits of data for 32-bit
> > devices */
> > #define PCI_MSI_MASK_32         12      /* Mask bits register for 32-bit
> > devices */
> > #define PCI_MSI_DATA_64         12      /* 16 bits of data for 64-bit
> > devices */
> > #define PCI_MSI_MASK_64         16      /* Mask bits register for 64-bit
> > devices */
> > 
> > 
> > If you want to move them, please send them upstream we'll merge when
> > they are there.
> 
> In fact, both defines are already in libpci. Since 3.0.0. Released 5
> years ago. OK, I'll send a header resync patch against a more recent
> release.
> 
> Then we should just lack something like PCI_MSIX_CTRL. I will have a look.

PCI_MSIX_FLAGS is the same.

> 
> Jan
>