From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53251) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QUQ61-0001yl-1I for qemu-devel@nongnu.org; Wed, 08 Jun 2011 17:15:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QUQ5z-00048z-7d for qemu-devel@nongnu.org; Wed, 08 Jun 2011 17:15:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62647) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QUQ5y-00048t-KN for qemu-devel@nongnu.org; Wed, 08 Jun 2011 17:15:23 -0400 Date: Thu, 9 Jun 2011 00:15:40 +0300 From: "Michael S. Tsirkin" Message-ID: <20110608211539.GF32260@redhat.com> References: <219d3206ad6eafed76d4f108a40912fe72884e19.1307550106.git.jan.kiszka@siemens.com> <20110608195316.GD30805@redhat.com> <4DEFE00A.5050005@web.de> <20110608210005.GB32260@redhat.com> <4DEFE374.7010009@web.de> <20110608210919.GD32260@redhat.com> <4DEFE589.2090009@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4DEFE589.2090009@web.de> Subject: Re: [Qemu-devel] [PATCH v2 8/9] msix: Align MSI-X constants to libpci definitions and extend them List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel On Wed, Jun 08, 2011 at 11:11:37PM +0200, Jan Kiszka wrote: > On 2011-06-08 23:09, Michael S. Tsirkin wrote: > > On Wed, Jun 08, 2011 at 11:02:44PM +0200, Jan Kiszka wrote: > >> On 2011-06-08 23:00, Michael S. Tsirkin wrote: > >>> On Wed, Jun 08, 2011 at 10:48:10PM +0200, Jan Kiszka wrote: > >>>> On 2011-06-08 21:53, Michael S. Tsirkin wrote: > >>>>> On Wed, Jun 08, 2011 at 06:21:51PM +0200, Jan Kiszka wrote: > >>>>>> Add PCI_MSIX_TABLE and PCI_MSIX_PBA, align other MSIX related constant > >>>>>> names to libpci style. Will be used for device assignment code in > >>>>>> qemu-kvm. > >>>>>> > >>>>>> Signed-off-by: Jan Kiszka > >>>>> > >>>>> Besides keeping pci_regs.h aligned with the original, > >>>>> I also think ideally pci register banging should stay > >>>>> within the pci subsystem. > >>>>> > >>>>> Could we add high-level APIs to help with that, > >>>>> instead of having kvm look at config space directly? > >>>> > >>>> We could move the related static inlines from msi/msix.c to the headers > >>>> in order to test for bits etc. Still, kvm needs to interpret the config > >>>> space of the assigned device, so the abstraction will remain rather low. > >>>> > >>>> Jan > >>>> > >>> > >>> Hmm, at least for MSI/MSIX I thought this is done by kvm in kernel? > >>> > >> > >> At least for the "traditional" assignment interface (VFIO may offload > >> something), no. User space does the cap analysis, filtering, and in the > >> MSI/MSI-X case the translation to QEMU msi/msix services. The latter is > >> even WIP in my tree. Surrent assignment open-codes this, missing many > >> corner cases. > >> > >> Jan > >> > > > > Anyway, if some defines need to be in a header, and aren't upstream > > yet, let's create pci_ext_regs.h and add a comment there that we > > should work on upstreaming them. > > Sounds good. But what is supposed to be upstream for us, the kernel or > pci-utils/libpci? > > Jan > It's currently the kernel, I don't really see a reason to change that. -- MST