From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:58189) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QV3hZ-0005y3-61 for qemu-devel@nongnu.org; Fri, 10 Jun 2011 11:32:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QV3hX-0003xX-5Y for qemu-devel@nongnu.org; Fri, 10 Jun 2011 11:32:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41294) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QV3hW-0003xI-Av for qemu-devel@nongnu.org; Fri, 10 Jun 2011 11:32:46 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5AFWjuZ017430 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 10 Jun 2011 11:32:45 -0400 Date: Fri, 10 Jun 2011 12:32:43 -0300 From: Luiz Capitulino Message-ID: <20110610123243.0b12b24c@doriath> In-Reply-To: <1307456313-9884-1-git-send-email-kwolf@redhat.com> References: <1307456313-9884-1-git-send-email-kwolf@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] block: Avoid direct AIO callback List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org On Tue, 7 Jun 2011 16:18:30 +0200 Kevin Wolf wrote: > This series fixes some cases of block drivers calling AIO callbacks too early. > It fixes the IDE assertion failure reported by Luiz (in error cases, the DMA > status, including acb, could first be reset in the callback and only then be > set by the caller, resulting in a dangling acb and wrong status register value). This fixes the reported bug, thanks. I know this is a different subject, but I'm still unable to use the host cdrom if the -snapshot flag is passed, I think the idea of ignoring the flag for a read-only device would fix this, no? > > Kevin Wolf (3): > qcow2: Avoid direct AIO callback > qcow: Avoid direct AIO callback > vdi: Avoid direct AIO callback > > block/qcow.c | 58 +++++++++++++++++++++++++++++++++++++++++++++++++++++++- > block/qcow2.c | 39 +++++++++++++++++++++++++++++-------- > block/vdi.c | 40 +++++++++++++++++++++++++++++++++++--- > 3 files changed, 122 insertions(+), 15 deletions(-) >