From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33163) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QWuqS-0001zy-V4 for qemu-devel@nongnu.org; Wed, 15 Jun 2011 14:29:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QWuqR-000616-Bj for qemu-devel@nongnu.org; Wed, 15 Jun 2011 14:29:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55939) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QWuqR-00060v-0m for qemu-devel@nongnu.org; Wed, 15 Jun 2011 14:29:39 -0400 Date: Wed, 15 Jun 2011 21:29:01 +0300 From: "Michael S. Tsirkin" Message-ID: <20110615182901.GA7197@redhat.com> References: <4DF8A940.40006@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4DF8A940.40006@windriver.com> Subject: Re: [Qemu-devel] [PATCH 06/10] kvm: remove unused variables List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chris Krumme Cc: Kevin Wolf , Anthony Liguori , Riku Voipio , Stefan Hajnoczi , kvm@vger.kernel.org, Jan Kiszka , Marcelo Tosatti , qemu-devel@nongnu.org, Alexander Graf , Blue Swirl , Isaku Yamahata , Alex Williamson , Gerd Hoffmann , Paolo Bonzini , Avi Kivity , Richard Henderson , Christoph Hellwig , Aurelien Jarno , Paul Brook On Wed, Jun 15, 2011 at 07:44:48AM -0500, Chris Krumme wrote: > On 06/14/2011 12:36 PM, Michael S. Tsirkin wrote: > >Signed-off-by: Michael S. Tsirkin > >--- > > hw/virtio-pci.h | 8 +++++--- > > target-i386/kvm.c | 3 +-- > > 2 files changed, 6 insertions(+), 5 deletions(-) > > > >diff --git a/hw/virtio-pci.h b/hw/virtio-pci.h > >index a4b5fd3..b518917 100644 > >--- a/hw/virtio-pci.h > >+++ b/hw/virtio-pci.h > >@@ -37,7 +37,9 @@ typedef struct { > > bool ioeventfd_started; > > } VirtIOPCIProxy; > > > >-extern void virtio_init_pci(VirtIOPCIProxy *proxy, VirtIODevice *vdev, > >- uint16_t vendor, uint16_t device, > >- uint16_t class_code, uint8_t pif); > >+void virtio_init_pci(VirtIOPCIProxy *proxy, VirtIODevice *vdev); > > Hello MST, > > The above change shows why we should be including a header, rather > than having private prototypes (w/bitrot). Which header? > >+ > >+/* Virtio ABI version, if we increment this, we break the guest driver. */ > >+#define VIRTIO_PCI_ABI_VERSION 0 > >+ > > This change seems unrelated. > > Thanks > > Chris Yes. > > #endif > >diff --git a/target-i386/kvm.c b/target-i386/kvm.c > >index faedc6c..58a70bc 100644 > >--- a/target-i386/kvm.c > >+++ b/target-i386/kvm.c > >@@ -970,7 +970,7 @@ static int kvm_get_xsave(CPUState *env) > > #ifdef KVM_CAP_XSAVE > > struct kvm_xsave* xsave; > > int ret, i; > >- uint16_t cwd, swd, twd, fop; > >+ uint16_t cwd, swd, twd; > > > > if (!kvm_has_xsave()) { > > return kvm_get_fpu(env); > >@@ -986,7 +986,6 @@ static int kvm_get_xsave(CPUState *env) > > cwd = (uint16_t)xsave->region[0]; > > swd = (uint16_t)(xsave->region[0]>> 16); > > twd = (uint16_t)xsave->region[1]; > >- fop = (uint16_t)(xsave->region[1]>> 16); > > env->fpstt = (swd>> 11)& 7; > > env->fpus = swd; > > env->fpuc = cwd;