From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:57522) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QWwyQ-0007b9-92 for qemu-devel@nongnu.org; Wed, 15 Jun 2011 16:46:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QWwyN-0001xJ-0E for qemu-devel@nongnu.org; Wed, 15 Jun 2011 16:46:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35668) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QWwyM-0001x1-2w for qemu-devel@nongnu.org; Wed, 15 Jun 2011 16:45:58 -0400 Date: Wed, 15 Jun 2011 23:46:11 +0300 From: "Michael S. Tsirkin" Message-ID: <20110615204611.GD8362@redhat.com> References: <80f46dacf63dc2c2cd363f37a45e42edde1549c0.1308073076.git.mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/2] get_maintainer: update to match qemu tree List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org On Wed, Jun 15, 2011 at 10:01:10PM +0300, Blue Swirl wrote: > On Tue, Jun 14, 2011 at 8:38 PM, Michael S. Tsirkin wr= ote: > > Signed-off-by: Michael S. Tsirkin Thanks, I've patched these. > > --- > > =A0scripts/get_maintainer.pl | =A0 29 +++++++---------------------- > > =A01 files changed, 7 insertions(+), 22 deletions(-) > > > > diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl > > index d29a8d7..c52ae59 100755 > > --- a/scripts/get_maintainer.pl > > +++ b/scripts/get_maintainer.pl > > @@ -258,9 +258,9 @@ if ($email && > > =A0 =A0 die "$P: Please select at least 1 email option\n"; > > =A0} > > > > -if (!top_of_kernel_tree($lk_path)) { > > +if (!top_of_tree($lk_path)) { > > =A0 =A0 die "$P: The current directory does not appear to be " > > - =A0 =A0 =A0 . "a linux kernel source tree.\n"; > > + =A0 =A0 =A0 . "a qemu source tree.\n"; >=20 > QEMU > > =A0} > > > > =A0## Read MAINTAINERS for type/value pairs > > @@ -792,7 +792,7 @@ Notes: > > =A0 =A0 =A0 =A0 =A0 --git-min-signatures, --git-max-maintainers, --gi= t-min-percent, and > > =A0 =A0 =A0 =A0 =A0 --git-blame > > =A0 =A0 =A0 Use --hg-since not --git-since to control date selection > > - =A0File ".get_maintainer.conf", if it exists in the linux kernel so= urce root > > + =A0File ".get_maintainer.conf", if it exists in the qemu source roo= t >=20 > QEMU >=20 > > =A0 =A0 =A0 directory, can change whatever get_maintainer defaults ar= e desired. > > =A0 =A0 =A0 Entries in this file can be any command line argument. > > =A0 =A0 =A0 This file is prepended to any additional command line arg= uments. > > @@ -800,28 +800,13 @@ Notes: > > =A0EOT > > =A0} > > > > -sub top_of_kernel_tree { > > +sub top_of_tree { > > =A0 =A0 my ($lk_path) =3D @_; > > > > =A0 =A0 if ($lk_path ne "" && substr($lk_path,length($lk_path)-1,1) n= e "/") { > > =A0 =A0 =A0 =A0$lk_path .=3D "/"; > > =A0 =A0 } > > - =A0 =A0if ( =A0 (-f "${lk_path}COPYING") > > - =A0 =A0 =A0 && (-f "${lk_path}CREDITS") > > - =A0 =A0 =A0 && (-f "${lk_path}Kbuild") > > - =A0 =A0 =A0 && (-f "${lk_path}MAINTAINERS") > > - =A0 =A0 =A0 && (-f "${lk_path}Makefile") > > - =A0 =A0 =A0 && (-f "${lk_path}README") > > - =A0 =A0 =A0 && (-d "${lk_path}Documentation") > > - =A0 =A0 =A0 && (-d "${lk_path}arch") > > - =A0 =A0 =A0 && (-d "${lk_path}include") > > - =A0 =A0 =A0 && (-d "${lk_path}drivers") > > - =A0 =A0 =A0 && (-d "${lk_path}fs") > > - =A0 =A0 =A0 && (-d "${lk_path}init") > > - =A0 =A0 =A0 && (-d "${lk_path}ipc") > > - =A0 =A0 =A0 && (-d "${lk_path}kernel") > > - =A0 =A0 =A0 && (-d "${lk_path}lib") > > - =A0 =A0 =A0 && (-d "${lk_path}scripts")) { > > + =A0 =A0if (-f "${lk_path}MAINTAINERS") { >=20 > The similar check in scripts/checkpatch.pl uses "COPYING", > "MAINTAINERS", "Makefile", "README", "docs", "VERSION", and "vl.c". > Please match that. >=20 > > =A0 =A0 =A0 =A0return 1; > > =A0 =A0 } > > =A0 =A0 return 0; > > @@ -1387,8 +1372,8 @@ sub vcs_exists { > > =A0 =A0 if (!$printed_novcs) { > > =A0 =A0 =A0 =A0warn("$P: No supported VCS found. =A0Add --nogit to op= tions?\n"); > > =A0 =A0 =A0 =A0warn("Using a git repository produces better results.\= n"); > > - =A0 =A0 =A0 warn("Try Linus Torvalds' latest git repository using:\= n"); > > - =A0 =A0 =A0 warn("git clone git://git.kernel.org/pub/scm/linux/kern= el/git/torvalds/linux-2.6.git\n"); > > + =A0 =A0 =A0 warn("Try latest git repository using:\n"); > > + =A0 =A0 =A0 warn("git clone git://git.qemu.org/qemu.git\n"); > > =A0 =A0 =A0 =A0$printed_novcs =3D 1; > > =A0 =A0 } > > =A0 =A0 return 0; > > -- > > 1.7.5.53.gc233e > > > >