From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:35722)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jdenemar@redhat.com>) id 1QX6zV-0002Uh-K6
	for qemu-devel@nongnu.org; Thu, 16 Jun 2011 03:27:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jdenemar@redhat.com>) id 1QX6zT-0005Zy-Tq
	for qemu-devel@nongnu.org; Thu, 16 Jun 2011 03:27:49 -0400
Received: from smtp.vivo.cz ([85.132.139.19]:60460)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jdenemar@redhat.com>) id 1QX6zT-0005Zb-Ex
	for qemu-devel@nongnu.org; Thu, 16 Jun 2011 03:27:47 -0400
Date: Thu, 16 Jun 2011 09:27:43 +0200
From: Jiri Denemark <jdenemar@redhat.com>
Message-ID: <20110616072743.GB514380@orkuz.home>
References: <20110615171403.158790293@amt.cnet>
	<20110615174009.094728634@amt.cnet>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110615174009.094728634@amt.cnet>
Subject: Re: [Qemu-devel] [patch 4/4] QEMU live block copy
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kwolf@redhat.com, Jes.Sorensen@redhat.com, dlaor@redhat.com, qemu-devel@nongnu.org, avi@redhat.com, stefanha@gmail.com

On Wed, Jun 15, 2011 at 14:14:07 -0300, Marcelo Tosatti wrote:
> Index: qemu-block-copy/qmp-commands.hx
> ===================================================================
> --- qemu-block-copy.orig/qmp-commands.hx
> +++ qemu-block-copy/qmp-commands.hx
...
>  SQMP
> +query-block-copy
> +-------------
> +
> +Live block copy status.
> +
> +Each block copy instance information is stored in a json-object and the returned
> +value is a json-array of all instances.
> +
> +Each json-object contains the following:
> +
> +- "device": device name (json-string)
> +- "status": block copy status (json-string)
> +    - Possible values: "active", "failed", "mirrored", "completed", meaning:
> +                    - failed: block copy failed.
> +                    - stopped: block copy stopped.
> +                    - active: block copy active, copying to destination image.
> +                    - mirrored: block copy active, finished copying to destination
> +                      image, writes are mirrored.
> +                    - completed: block copy completed.
> +
> +- "info": A json-object with the statistics information, if status is "active":
> +    - "percentage": percentage completed (json-int)
> +
> +Example:
> +
> +Block copy for "ide1-hd0" active and block copy for "ide1-hd1" failed:
> +
> +-> { "execute": "query-block-copy" }
> +<- {
> +      "return":[
> +        {"device":"ide1-hd0",
> +            "status":"active",
> +            "info":{
> +               "percentage":23,
> +            }
> +        },
> +        {"device":"ide1-hd1",
> +         "status":"failed"
> +        }
> +      ]
> +   }
> +
> +EQMP

This documentation doesn't reflect the changes to progress reporting you made
in the code.

> Index: qemu-block-copy/docs/block_copy.txt
> ===================================================================
> --- /dev/null
> +++ qemu-block-copy/docs/block_copy.txt
...
> +Migration
> +=========
> +
> +It is necessary to specify active block copy instance in the destination
> +VM before migration is performed. Example:
> +
> +1) start VM in incoming mode.
> +2) for each active block copy instance on the source, run:
> +    (qemu) block_copy device /path/to/image.dst [-i] -m
> +
> +

I guess I'm a bit behind but what exactly can this migration support in
block_copy be used for?

Jirka