From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51722) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QYgi2-0003ar-DT for qemu-devel@nongnu.org; Mon, 20 Jun 2011 11:48:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QYgi0-000154-Up for qemu-devel@nongnu.org; Mon, 20 Jun 2011 11:48:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46852) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QYgi0-00014l-H7 for qemu-devel@nongnu.org; Mon, 20 Jun 2011 11:48:16 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5KFmF2I016718 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 20 Jun 2011 11:48:15 -0400 Date: Mon, 20 Jun 2011 17:48:05 +0200 From: Alon Levy Message-ID: <20110620154805.GF28412@bow.redhat.com> References: <1308568312-5463-1-git-send-email-alevy@redhat.com> <1308568312-5463-3-git-send-email-alevy@redhat.com> <4DFF3970.8000804@redhat.com> <20110620125821.GB28412@bow.redhat.com> <4DFF543F.9070205@redhat.com> <20110620151107.GE28412@bow.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110620151107.GE28412@bow.redhat.com> Subject: Re: [Qemu-devel] [PATCH 2/2] qxl: add QXL_IO_UPDATE_MEM for guest S3&S4 support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , qemu-devel@nongnu.org, yhalperi@redhat.com On Mon, Jun 20, 2011 at 05:11:07PM +0200, Alon Levy wrote: > On Mon, Jun 20, 2011 at 04:07:59PM +0200, Gerd Hoffmann wrote: > > >>What is the difference to one worker->stop() + worker->start() cycle? > > >> > > > > > >ok, stop+start won't disconnect any clients either. But does stop render all waiting commands? > > >I'll have to look, I don't know if it does. > > > > It does. This is what qemu uses to flush all spice server state to > > device memory on migration. > > > > What is the reason for deleting all surfaces? > > Making sure all references are dropped to pci memory in devram. We would need to recreate all > the surfaces after reset anyway. That's not right. The reason is that for the windows driver I don't know if this is a resolution change or a suspend. So it was easier to destroy all the surfaces and then the two cases are equal - before going to sleep / leaving the current resolution I destroy all the surfaces, when coming back I recreate the surfaces. If it's a resolution change there is no coming back stage, but since all surfaces are destroyed there is no error when the same surface id's are reused. > > > > > cheers, > > Gerd > > >