From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45600) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QZFRa-0007ZP-S1 for qemu-devel@nongnu.org; Wed, 22 Jun 2011 00:53:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QZFRZ-0001HG-UA for qemu-devel@nongnu.org; Wed, 22 Jun 2011 00:53:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57357) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QZFRZ-0001HB-H9 for qemu-devel@nongnu.org; Wed, 22 Jun 2011 00:53:37 -0400 Date: Wed, 22 Jun 2011 10:23:30 +0530 From: Amit Shah Message-ID: <20110622045330.GB5789@amit-x200.redhat.com> References: <20110616133849.02fb4bea@doriath> <20110617064736.GA18513@amit-x200.redhat.com> <20110617101644.5e275e53@doriath> <20110617160926.GA25648@amit-x200.redhat.com> <20110617150811.156acbae@doriath> <20110618034245.GA26613@amit-x200.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] virtio-serial: Fix segfault on guest boot List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: mdroth@linux.vnet.ibm.com, Markus Armbruster , qemu-devel , Luiz Capitulino On (Sun) 19 Jun 2011 [00:43:20], Blue Swirl wrote: > On Sat, Jun 18, 2011 at 6:42 AM, Amit Shah wrote= : > > On (Fri) 17 Jun 2011 [15:08:11], Luiz Capitulino wrote: > > > >> > > =A0 =A0 =A0 =A0 =A0if (!cpkt.value) { > >> > > - =A0 =A0 =A0 =A0 =A0 =A0error_report("virtio-serial-bus: Guest = failure in adding device %s\n", > >> > > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 vser->bus.qbus= .name); > >> > > - =A0 =A0 =A0 =A0 =A0 =A0break; > >> > > + =A0 =A0 =A0 =A0 =A0 =A0error_report("virtio-serial-bus: Guest = failure in adding device %s\n", vser->bus.qbus.name); > >> > > + =A0 =A0 =A0 =A0 =A0 =A0return; > >> > > >> > The line split should remain -- else it goes beyond 80 chars. > >> > >> It's already beyond 80 chars to me. > > > > I prefer to not break strings that get printed out -- makes it easier > > for greppers to find out the source of the string. >=20 > Please read CODING_STYLE and use scripts/checkpatch.pl before > submitting patches. Good sense should dictate what goes in CODING_STYLE, not the other way around. >>From dec93d9eccd639f7bfd1343dca65fa112eb19e3e Mon Sep 17 00:00:00 2001 Message-Id: From: Amit Shah Date: Wed, 22 Jun 2011 10:20:48 +0530 Subject: [PATCH 1/1] CODING_STYLE: Add exception for log output 80-char l= imit Output that's logged can be beyond 80 chars to preserve sane grepping. Signed-off-by: Amit Shah --- CODING_STYLE | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/CODING_STYLE b/CODING_STYLE index 5ecfa22..886221c 100644 --- a/CODING_STYLE +++ b/CODING_STYLE @@ -31,7 +31,10 @@ Do not leave whitespace dangling off the ends of lines. =20 2. Line width =20 -Lines are 80 characters; not longer. +Lines are 80 characters; not longer. An exception is for output that +is logged, for example via fprintf() / error_report() functions, +making it straightforward for people to grep the code for the source +of the output. =20 Rationale: - Some people like to tile their 24" screens with a 6x4 matrix of 80x24 --=20 1.7.5.4 Amit