From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:58095)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1QanDC-0006xr-00
	for qemu-devel@nongnu.org; Sun, 26 Jun 2011 07:09:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1QanDA-0003Rh-QE
	for qemu-devel@nongnu.org; Sun, 26 Jun 2011 07:09:09 -0400
Received: from mx1.redhat.com ([209.132.183.28]:21835)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1QanDA-0003RS-9t
	for qemu-devel@nongnu.org; Sun, 26 Jun 2011 07:09:08 -0400
Date: Sun, 26 Jun 2011 14:08:36 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20110626110836.GA5218@redhat.com>
References: <cover.1308072799.git.mst@redhat.com>
	<dd745620661c4470581ed3e40c282a0fe6fbc434.1308072799.git.mst@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <dd745620661c4470581ed3e40c282a0fe6fbc434.1308072799.git.mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 09/10] exec: remove unused variable
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, Marcelo Tosatti <mtosatti@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, kvm@vger.kernel.org, Isaku Yamahata <yamahata@valinux.co.jp>, Jan Kiszka <jan.kiszka@siemens.com>, Riku Voipio <riku.voipio@iki.fi>, Alexander Graf <agraf@suse.de>, Christoph Hellwig <hch@lst.de>, Blue Swirl <blauwirbel@gmail.com>, Alex Williamson <alex.williamson@redhat.com>, Paul Brook <paul@codesourcery.com>, Paolo Bonzini <pbonzini@redhat.com>, Avi Kivity <avi@redhat.com>, Aurelien Jarno <aurelien@aurel32.net>, Richard Henderson <rth@twiddle.net>

On Tue, Jun 14, 2011 at 08:36:26PM +0300, Michael S. Tsirkin wrote:
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Any comments on this one?

> ---
>  exec.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/exec.c b/exec.c
> index 81808f4..b784f08 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -1207,12 +1207,16 @@ static inline void tb_alloc_page(TranslationBlock *tb,
>                                   unsigned int n, tb_page_addr_t page_addr)
>  {
>      PageDesc *p;
> +#if !defined(CONFIG_USER_ONLY)
>      TranslationBlock *last_first_tb;
> +#endif
>  
>      tb->page_addr[n] = page_addr;
>      p = page_find_alloc(page_addr >> TARGET_PAGE_BITS, 1);
>      tb->page_next[n] = p->first_tb;
> +#if !defined(CONFIG_USER_ONLY)
>      last_first_tb = p->first_tb;
> +#endif
>      p->first_tb = (TranslationBlock *)((long)tb | n);
>      invalidate_page_bitmap(p);
>  
> -- 
> 1.7.5.53.gc233e