From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:38517)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1QapAF-0005Po-Ej
	for qemu-devel@nongnu.org; Sun, 26 Jun 2011 09:14:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1QapAD-0002dN-5u
	for qemu-devel@nongnu.org; Sun, 26 Jun 2011 09:14:15 -0400
Received: from mx1.redhat.com ([209.132.183.28]:52660)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1QapAC-0002dJ-LZ
	for qemu-devel@nongnu.org; Sun, 26 Jun 2011 09:14:12 -0400
Date: Sun, 26 Jun 2011 16:14:16 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20110626131416.GA7513@redhat.com>
References: <alpine.DEB.2.00.1106161645230.12963@kaball-desktop>
	<1308240319-13949-1-git-send-email-stefano.stabellini@eu.citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1308240319-13949-1-git-send-email-stefano.stabellini@eu.citrix.com>
Subject: Re: [Qemu-devel] [PATCH RESEND 1/3] xen: Add the Xen platform pci
	device
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: stefano.stabellini@eu.citrix.com
Cc: Steven Smith <ssmith@xensource.com>, Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xensource.com, qemu-devel@nongnu.org, agraf@suse.de

On Thu, Jun 16, 2011 at 05:05:17PM +0100, stefano.stabellini@eu.citrix.com wrote:
> diff --git a/hw/pci_ids.h b/hw/pci_ids.h
> index d9457ed..d94578c 100644
> --- a/hw/pci_ids.h
> +++ b/hw/pci_ids.h
> @@ -109,3 +109,5 @@
>  #define PCI_DEVICE_ID_INTEL_82371AB      0x7111
>  #define PCI_DEVICE_ID_INTEL_82371AB_2    0x7112
>  #define PCI_DEVICE_ID_INTEL_82371AB_3    0x7113
> +
> +#define PCI_VENDOR_ID_XENSOURCE          0x5853

Please stick to names in  include/linux/pci_ids.h
in the linux tree.

$ grep XEN /scm/linux-2.6/include/linux/pci_ids.h 
#define PCI_VENDOR_ID_NETXEN            0x4040
#define PCI_VENDOR_ID_XEN               0x5853
#define PCI_DEVICE_ID_XEN_PLATFORM      0x0001



> diff --git a/hw/xen_platform.c b/hw/xen_platform.c
> new file mode 100644
> index 0000000..b167eee

...

> +
> +    pci_config_set_vendor_id(pci_conf, PCI_VENDOR_ID_XENSOURCE);
> +    pci_config_set_device_id(pci_conf, 0x0001);

PCI_DEVICE_ID_XEN_PLATFORM

> +    pci_set_word(pci_conf + PCI_SUBSYSTEM_VENDOR_ID, PCI_VENDOR_ID_XENSOURCE);
> +    pci_set_word(pci_conf + PCI_SUBSYSTEM_ID, 0x0001);

Same.