From: Amit Shah <amit.shah@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: mdroth@linux.vnet.ibm.com, Markus Armbruster <armbru@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] 80-column rule and breaking output statements
Date: Mon, 27 Jun 2011 15:18:30 +0530 [thread overview]
Message-ID: <20110627094830.GE9369@amit-x200.redhat.com> (raw)
In-Reply-To: <BANLkTi=iWixQz-TuoXfi+ZS45ekY9KbruA@mail.gmail.com>
On (Sun) 26 Jun 2011 [20:43:16], Blue Swirl wrote:
> On Wed, Jun 22, 2011 at 7:53 AM, Amit Shah <amit.shah@redhat.com> wrote:
[snip]
> > From dec93d9eccd639f7bfd1343dca65fa112eb19e3e Mon Sep 17 00:00:00 2001
> > Message-Id: <dec93d9eccd639f7bfd1343dca65fa112eb19e3e.1308718380.git.amit.shah@redhat.com>
> > From: Amit Shah <amit.shah@redhat.com>
> > Date: Wed, 22 Jun 2011 10:20:48 +0530
> > Subject: [PATCH 1/1] CODING_STYLE: Add exception for log output 80-char limit
> >
> > Output that's logged can be beyond 80 chars to preserve sane grepping.
>
> Nack. Grepping (why just logs?) is just one use case. There are other
I'm not talking about grepping logs. I'm talking about grepping code
once you have something in the logs. With line breaks in the code but
not in the log, you will not get the desired result.
Example:
fprintf("This is a line ");
fprintf("broken in two code lines\n");
Output is:
This is a line broken in two code lines
Picking that line from the output and grepping for it in the source
doesn't get you what you want.
Amit
next prev parent reply other threads:[~2011-06-27 9:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-16 16:38 [Qemu-devel] [PATCH] virtio-serial: Fix segfault on guest boot Luiz Capitulino
2011-06-17 6:47 ` Amit Shah
2011-06-17 7:47 ` Markus Armbruster
2011-06-17 8:44 ` Amit Shah
2011-06-17 13:16 ` Luiz Capitulino
2011-06-17 13:21 ` Luiz Capitulino
2011-06-17 16:09 ` Amit Shah
2011-06-17 18:08 ` Luiz Capitulino
2011-06-18 3:42 ` Amit Shah
2011-06-18 21:43 ` Blue Swirl
2011-06-22 4:53 ` Amit Shah
2011-06-26 17:43 ` Blue Swirl
2011-06-27 9:48 ` Amit Shah [this message]
2011-07-01 19:43 ` [Qemu-devel] 80-column rule and breaking output statements Blue Swirl
2011-07-02 8:38 ` Stefan Hajnoczi
2011-07-04 6:05 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110627094830.GE9369@amit-x200.redhat.com \
--to=amit.shah@redhat.com \
--cc=armbru@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=lcapitulino@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).