From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:56387)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1Qb8R1-0002H6-MO
	for qemu-devel@nongnu.org; Mon, 27 Jun 2011 05:48:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1Qb8Qy-0007Tj-Ua
	for qemu-devel@nongnu.org; Mon, 27 Jun 2011 05:48:51 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50673)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1Qb8Qy-0007TU-8P
	for qemu-devel@nongnu.org; Mon, 27 Jun 2011 05:48:48 -0400
Date: Mon, 27 Jun 2011 15:18:30 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20110627094830.GE9369@amit-x200.redhat.com>
References: <20110616133849.02fb4bea@doriath>
	<20110617064736.GA18513@amit-x200.redhat.com>
	<20110617101644.5e275e53@doriath>
	<20110617160926.GA25648@amit-x200.redhat.com>
	<20110617150811.156acbae@doriath>
	<20110618034245.GA26613@amit-x200.redhat.com>
	<BANLkTinkCkpyP0JDWu5bhAT=XgFbo=ritQ@mail.gmail.com>
	<20110622045330.GB5789@amit-x200.redhat.com>
	<BANLkTi=iWixQz-TuoXfi+ZS45ekY9KbruA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <BANLkTi=iWixQz-TuoXfi+ZS45ekY9KbruA@mail.gmail.com>
Subject: Re: [Qemu-devel] 80-column rule and breaking output statements
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: mdroth@linux.vnet.ibm.com, Markus Armbruster <armbru@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Luiz Capitulino <lcapitulino@redhat.com>

On (Sun) 26 Jun 2011 [20:43:16], Blue Swirl wrote:
> On Wed, Jun 22, 2011 at 7:53 AM, Amit Shah <amit.shah@redhat.com> wrote:

[snip]

> > From dec93d9eccd639f7bfd1343dca65fa112eb19e3e Mon Sep 17 00:00:00 2001
> > Message-Id: <dec93d9eccd639f7bfd1343dca65fa112eb19e3e.1308718380.git.amit.shah@redhat.com>
> > From: Amit Shah <amit.shah@redhat.com>
> > Date: Wed, 22 Jun 2011 10:20:48 +0530
> > Subject: [PATCH 1/1] CODING_STYLE: Add exception for log output 80-char limit
> >
> > Output that's logged can be beyond 80 chars to preserve sane grepping.
> 
> Nack. Grepping (why just logs?) is just one use case. There are other

I'm not talking about grepping logs.  I'm talking about grepping code
once you have something in the logs.  With line breaks in the code but
not in the log, you will not get the desired result.

Example:


fprintf("This is a line ");
fprintf("broken in two code lines\n");


Output is:

This is a line broken in two code lines


Picking that line from the output and grepping for it in the source
doesn't get you what you want.

		Amit