From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:55160)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1Qbr7S-0001ch-H7
	for qemu-devel@nongnu.org; Wed, 29 Jun 2011 05:31:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1Qbr7R-0007P1-09
	for qemu-devel@nongnu.org; Wed, 29 Jun 2011 05:31:38 -0400
Received: from mx1.redhat.com ([209.132.183.28]:45443)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1Qbr7Q-0007Ox-H1
	for qemu-devel@nongnu.org; Wed, 29 Jun 2011 05:31:36 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5T9VZqm005306
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 29 Jun 2011 05:31:35 -0400
Date: Wed, 29 Jun 2011 11:31:22 +0200
From: Alon Levy <alevy@redhat.com>
Message-ID: <20110629093122.GP30873@bow.redhat.com>
References: <1308920577-31569-1-git-send-email-alevy@redhat.com>
	<1308920577-31569-5-git-send-email-alevy@redhat.com>
	<4E0AEEBD.9000002@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4E0AEEBD.9000002@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] qxl: allow QXL_IO_LOG also in vga
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: yhalperi@redhat.com, qemu-devel@nongnu.org

On Wed, Jun 29, 2011 at 11:22:05AM +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> >The driver may change us to vga mode and still issue a QXL_IO_LOG,
> >which we can easily support.
> 
> >@@ -1001,9 +1001,9 @@ static void ioport_write(void *opaque, uint32_t addr, uint32_t val)
> >-    case QXL_IO_LOG:
> >      case QXL_IO_CREATE_PRIMARY_ASYNC:
> >      case QXL_IO_UPDATE_IRQ:
> >+    case QXL_IO_LOG:
> >          break;
> 
> That is a NOP, and it also doesn't apply.  It isn't the only patch
> which doesn't apply cleanly, looks like your series isn't based on
> upstream/master ...

Yeah, my bad. I did something wierd, and missed this. I'll send a v3. Do you have other comments?

Unrelated, but have you looked at the async patches that I sent, and yonit's comments?
 - (me) catch EINTR and EAGAIN in async thread read
 - (yonit) reset surfaces count and surfaces when doing destroy_all

And I think there were some others I forget.

> 
> cheers,
>   Gerd