From: Alon Levy <alevy@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: yhalperi@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] qxl: allow QXL_IO_LOG also in vga
Date: Wed, 29 Jun 2011 13:43:26 +0200 [thread overview]
Message-ID: <20110629114326.GT30873@bow.redhat.com> (raw)
In-Reply-To: <4E0AF836.3030507@redhat.com>
On Wed, Jun 29, 2011 at 12:02:30PM +0200, Gerd Hoffmann wrote:
> Hi,
>
> >Yeah, my bad. I did something wierd, and missed this. I'll send a v3. Do you have other comments?
>
> I stopped looking after figuring stuff doesn't apply to master.
>
> >Unrelated, but have you looked at the async patches that I sent, and yonit's comments?
> > - (me) catch EINTR and EAGAIN in async thread read
> > - (yonit) reset surfaces count and surfaces when doing destroy_all
>
> http://cgit.freedesktop.org/spice/qemu/log/?h=bz700134 is what I
> currently have. Some of your patches are in there already.
I tried rebasing on that, testing showed there was a deadlock, you can't reuse wlock for
track_command since it is called from interface_get_command, called from red_worker, which
may be during update_area, which already took the wlock. Adding a separate track_lock will
probably work.
>
> cheers,
> Gerd
>
next prev parent reply other threads:[~2011-06-29 11:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-24 13:02 [Qemu-devel] [PATCH v2] S3&S4 support Alon Levy
2011-06-24 13:02 ` [Qemu-devel] [PATCH v2] qxl: set mm_time in vga update Alon Levy
2011-06-24 13:02 ` [Qemu-devel] [PATCH v2] qxl: interface_get_command: fix reported mode Alon Levy
2011-06-24 13:02 ` [Qemu-devel] [PATCH v2] qxl: add mode to debugprint on destroy primary Alon Levy
2011-06-24 13:02 ` [Qemu-devel] [PATCH v2] qxl: allow QXL_IO_LOG also in vga Alon Levy
2011-06-29 9:22 ` Gerd Hoffmann
2011-06-29 9:31 ` Alon Levy
2011-06-29 10:02 ` Gerd Hoffmann
2011-06-29 11:43 ` Alon Levy [this message]
2011-06-24 13:02 ` [Qemu-devel] [PATCH v2] qxl: abort on panic instead of exit Alon Levy
2011-06-24 13:02 ` [Qemu-devel] [PATCH v2] qxl-logger: add timestamp to command log Alon Levy
2011-06-24 13:02 ` [Qemu-devel] [PATCH v2] qxl: update and add debug prints Alon Levy
2011-06-24 13:02 ` [Qemu-devel] [PATCH v2] qxl: add dev id to guest prints Alon Levy
2011-06-24 13:02 ` [Qemu-devel] [PATCH v2] qxl: add io_port_to_string Alon Levy
2011-06-24 13:02 ` [Qemu-devel] [PATCH v2] qxl: update revision to QXL_REVISION_STABLE_V10 Alon Levy
2011-06-24 13:02 ` [Qemu-devel] [PATCH v2] qxl: add QXL_IO_FLUSH_{SURFACES, RELEASE} for guest S3&S4 support Alon Levy
2011-06-24 13:02 ` [Qemu-devel] [PATCH v2] qxl: add primary_created state, change mode lifetimes Alon Levy
2011-06-27 7:42 ` yhalperi
2011-06-27 8:21 ` Alon Levy
2011-06-29 8:41 ` Gerd Hoffmann
2011-06-29 9:23 ` Alon Levy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110629114326.GT30873@bow.redhat.com \
--to=alevy@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yhalperi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).