From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:44591)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1QbuY1-0007Ky-Rh
	for qemu-devel@nongnu.org; Wed, 29 Jun 2011 09:11:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1QbuY0-0004Vu-8J
	for qemu-devel@nongnu.org; Wed, 29 Jun 2011 09:11:17 -0400
Received: from mx1.redhat.com ([209.132.183.28]:5203)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1QbuXz-0004Vn-QN
	for qemu-devel@nongnu.org; Wed, 29 Jun 2011 09:11:16 -0400
Date: Wed, 29 Jun 2011 16:11:24 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20110629131124.GA18283@redhat.com>
References: <20110628153516.GA8596@redhat.com>
	<823452D2-B620-40F2-8423-917947A0F3A3@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <823452D2-B620-40F2-8423-917947A0F3A3@suse.de>
Subject: Re: [Qemu-devel] [PATCH] Add compat eventfd header
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>, jan.kiszka@web.de, Paolo Bonzini <pbonzini@redhat.com>, Aurelien Jarno <aurelien@aurel32.net>

On Wed, Jun 29, 2011 at 03:02:46PM +0200, Alexander Graf wrote:
> 
> On 28.06.2011, at 17:35, Michael S. Tsirkin wrote:
> 
> > Support build on RHEL 5.X where we have syscall for eventfd but not
> > userspace wrapper.
> > 
> > (cherry-picked from commit 9e3269181e9bc56feb43bcd4e8ce0b82cd543e65
> > in qemu-kvm.git).
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > compat/sys/eventfd.h |   13 +++++++++++++
> > configure            |    4 +++
> > 2 files changed, 16 insertions(+), 0 deletions(-)
> > create mode 100644 compat/sys/eventfd.h
> > 
> > diff --git a/compat/sys/eventfd.h b/compat/sys/eventfd.h
> > new file mode 100644
> > index 0000000..f55d96a
> > --- /dev/null
> > +++ b/compat/sys/eventfd.h
> > @@ -0,0 +1,13 @@
> > +#ifndef _COMPAT_SYS_EVENTFD
> > +#define _COMPAT_SYS_EVENTFD
> > +
> > +#include <unistd.h>
> > +#include <syscall.h>
> > +
> > +
> > +static inline int eventfd (int count, int flags)
> 
> coding style seems wrong.

What exactly? Two empty lines?

> However, I'm not sure I like the idea of adding this code in qemu. Wouldn't the RHEL5 libc be a better place for such a wrapper?
> 
> 
> Alex

My guess (I don't speak for red hat here) is that's unlikely to be
patched anytime soon.  It helps me when I need to use such a box,
and the cost seems negligeable. What's the drawback?

-- 
MST