From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45339) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qbvgm-000204-AH for qemu-devel@nongnu.org; Wed, 29 Jun 2011 10:24:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qbvgk-0003tZ-Gl for qemu-devel@nongnu.org; Wed, 29 Jun 2011 10:24:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6853) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qbvgj-0003tV-Ue for qemu-devel@nongnu.org; Wed, 29 Jun 2011 10:24:22 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5TEOL6r002703 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 29 Jun 2011 10:24:21 -0400 Date: Wed, 29 Jun 2011 16:24:08 +0200 From: Alon Levy Message-ID: <20110629142408.GW30873@bow.redhat.com> References: <1309348641-20061-1-git-send-email-alevy@redhat.com> <1309348641-20061-7-git-send-email-alevy@redhat.com> <4E0B1E1B.4070803@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E0B1E1B.4070803@redhat.com> Subject: Re: [Qemu-devel] [PATCHv3] qxl: abort on panic instead of exit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: yhalperi@redhat.com, qemu-devel@nongnu.org On Wed, Jun 29, 2011 at 02:44:11PM +0200, Gerd Hoffmann wrote: > On 06/29/11 13:57, Alon Levy wrote: > >--- > > hw/qxl.h | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > >diff --git a/hw/qxl.h b/hw/qxl.h > >index 7df594e..bf875a0 100644 > >--- a/hw/qxl.h > >+++ b/hw/qxl.h > >@@ -89,7 +89,7 @@ typedef struct PCIQXLDevice { > > > > #define PANIC_ON(x) if ((x)) { \ > > printf("%s: PANIC %s failed\n", __FUNCTION__, #x); \ > >- exit(-1); \ > >+ abort(); \ > > } > > Not urgent, but I think this should change. A bunch of the PANIC_ON > checks are guest-triggerable. Long-term I want invalid requests > from the guest just be ignored by default. Keeping an option to do > something else is fine (log a message, abort, write out guest dump, > whatever), I see that this can be quite useful for guest driver > debugging. Agreed. So keep PANIC_ON but remove a lot of it's users, or add some wrapper that depends on a "guest_panic" parameter that defaults off. > > cheers, > Gerd